From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Hansen Newsgroups: gmane.emacs.devel Subject: Re: Octave Help Mode? Date: Tue, 15 Apr 2008 20:21:18 +0200 Organization: disorganized Message-ID: <87bq4bc735.fsf@localhorst.mine.nu> References: <87wsmzd1pa.fsf@localhorst.mine.nu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1208284413 23127 80.91.229.12 (15 Apr 2008 18:33:33 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 15 Apr 2008 18:33:33 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Apr 15 20:34:03 2008 connect(): Connection refused Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JlppF-00030a-HW for ged-emacs-devel@m.gmane.org; Tue, 15 Apr 2008 20:24:13 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Jlpob-0008To-4C for ged-emacs-devel@m.gmane.org; Tue, 15 Apr 2008 14:23:33 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JlpoW-0008Sj-LM for emacs-devel@gnu.org; Tue, 15 Apr 2008 14:23:28 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JlpoT-0008RR-58 for emacs-devel@gnu.org; Tue, 15 Apr 2008 14:23:27 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JlpoS-0008RO-W6 for emacs-devel@gnu.org; Tue, 15 Apr 2008 14:23:25 -0400 Original-Received: from main.gmane.org ([80.91.229.2] helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JlpoS-00076q-DL for emacs-devel@gnu.org; Tue, 15 Apr 2008 14:23:24 -0400 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1JlpoP-0004k8-CY for emacs-devel@gnu.org; Tue, 15 Apr 2008 18:23:21 +0000 Original-Received: from e178020046.adsl.alicedsl.de ([85.178.20.46]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 15 Apr 2008 18:23:21 +0000 Original-Received: from david.hansen by e178020046.adsl.alicedsl.de with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 15 Apr 2008 18:23:21 +0000 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: emacs-devel@gnu.org Original-Lines: 99 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: e178020046.adsl.alicedsl.de Mail-Copies-To: nobody User-Agent: Gnus/5.110009 (No Gnus v0.9) Emacs/23.0.60 (gnu/linux) Cancel-Lock: sha1:12AHJA98oDLSEu5A/1vsjBtkSlw= X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:95303 Archived-At: --=-=-= On Tue, 15 Apr 2008 11:55:17 -0400 Stefan Monnier wrote: >> Is there any need for `octave-help' if `info-lookup-symbol' is doing >> the same (as far as I can see)? > > I haven't looked at octave-help, but maybe it is indeed redundant. > Can someone check? Well, I just did. It does indeed nothing more than `info-lookup-symbol'. I suggest to remove octave-hlp.el and applying the attached patch. But it can't hurt to wait a bit and give the maintainer a chance to have his word. David --=-=-= Content-Type: text/x-patch Content-Disposition: inline *** octave-mod.el.~1.44.~ 2008-02-17 01:40:24.000000000 +0100 --- octave-mod.el 2008-04-15 20:13:12.000000000 +0200 *************** *** 31,44 **** ;; It defines Octave mode, a major mode for editing ;; Octave code. - ;; The file octave-hlp.el provides `octave-help', a facility for looking up - ;; documentation on a symbol in the Octave info files. - ;; The file octave-inf.el contains code for interacting with an inferior ;; Octave process using comint. ! ;; See the documentation of `octave-mode', `octave-help' and ! ;; `run-octave' for further information on usage and customization. ;;; Code: (require 'custom) --- 31,41 ---- ;; It defines Octave mode, a major mode for editing ;; Octave code. ;; The file octave-inf.el contains code for interacting with an inferior ;; Octave process using comint. ! ;; See the documentation of `octave-mode' and `run-octave' for further ! ;; information on usage and customization. ;;; Code: (require 'custom) *************** *** 224,230 **** (define-key map "\C-c\M-\C-h" 'octave-mark-block) (define-key map "\C-c]" 'octave-close-block) (define-key map "\C-c\C-f" 'octave-insert-defun) ! (define-key map "\C-c\C-h" 'octave-help) (define-key map "\C-c\C-il" 'octave-send-line) (define-key map "\C-c\C-ib" 'octave-send-block) (define-key map "\C-c\C-if" 'octave-send-defun) --- 221,227 ---- (define-key map "\C-c\M-\C-h" 'octave-mark-block) (define-key map "\C-c]" 'octave-close-block) (define-key map "\C-c\C-f" 'octave-insert-defun) ! (define-key map "\C-c\C-h" 'info-lookup-symbol) (define-key map "\C-c\C-il" 'octave-send-line) (define-key map "\C-c\C-ib" 'octave-send-block) (define-key map "\C-c\C-if" 'octave-send-defun) *************** *** 283,289 **** ["Submit Bug Report" octave-submit-bug-report t] "-" ["Describe Octave Mode" octave-describe-major-mode t] ! ["Lookup Octave Index" octave-help t]) "Menu for Octave mode.") (defvar octave-mode-syntax-table --- 280,286 ---- ["Submit Bug Report" octave-submit-bug-report t] "-" ["Describe Octave Mode" octave-describe-major-mode t] ! ["Lookup Octave Index" info-lookup-symbol t]) "Menu for Octave mode.") (defvar octave-mode-syntax-table *************** *** 1517,1523 **** 'octave-comment-char 'octave-continuation-offset 'octave-continuation-string - 'octave-help-files 'octave-send-echo-input 'octave-send-line-auto-forward 'octave-send-show-buffer)))) --- 1514,1519 ---- --=-=-=--