From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: bug#636: Please fix before the release of 23.1 Date: Mon, 11 Aug 2008 17:42:22 -0400 Message-ID: <87bpzzfcu9.fsf@stupidchicken.com> References: <877ibp4hh3.fsf@vorlon.ganneff.de> <871w1xfmsb.fsf@grepfind.mwolson.org> <87ljzj3oad.fsf_-_@grepfind.mwolson.org> <18590.45488.891078.545308@a1ihome1.kph.uni-mainz.de> <18590.47471.82980.734389@a1ihome1.kph.uni-mainz.de> <87ljz45xfj.fsf@stupidchicken.com> <18591.59359.40969.641357@a1ihome1.kph.uni-mainz.de> <87fxpb5xbn.fsf@stupidchicken.com> <20080811190124.GB28138@muc.de> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1218490957 18031 80.91.229.12 (11 Aug 2008 21:42:37 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 11 Aug 2008 21:42:37 +0000 (UTC) Cc: 636-done@emacsbugs.donarmstrong.com, Glenn Morris , Ulrich Mueller , Michael Olson , emacs-devel@gnu.org To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Aug 11 23:43:28 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KSfAS-0005KA-8d for ged-emacs-devel@m.gmane.org; Mon, 11 Aug 2008 23:43:08 +0200 Original-Received: from localhost ([127.0.0.1]:39821 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KSf9V-0001hR-QN for ged-emacs-devel@m.gmane.org; Mon, 11 Aug 2008 17:42:09 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KSf9R-0001e5-8q for emacs-devel@gnu.org; Mon, 11 Aug 2008 17:42:05 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KSf9Q-0001cq-N6 for emacs-devel@gnu.org; Mon, 11 Aug 2008 17:42:04 -0400 Original-Received: from [199.232.76.173] (port=35513 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KSf9Q-0001cW-EO for emacs-devel@gnu.org; Mon, 11 Aug 2008 17:42:04 -0400 Original-Received: from cyd.mit.edu ([18.115.2.24]:45865 helo=cyd) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KSf9J-00043y-4E; Mon, 11 Aug 2008 17:41:57 -0400 Original-Received: by cyd (Postfix, from userid 1000) id B7A9A57E2B5; Mon, 11 Aug 2008 17:42:22 -0400 (EDT) In-Reply-To: <20080811190124.GB28138@muc.de> (Alan Mackenzie's message of "Mon, 11 Aug 2008 19:01:24 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:102302 Archived-At: Alan Mackenzie writes: > The way I see it, it's a bug in `beginning-of-defun'. The docstring > says that a non-nil `beginning-of-defun-function' finds the pertinent > place, but beginning-of-defun then moves point somewhere else. I HATE > things that are ostensibly "helpful", but in reality are dumbing down, > and mainly just foul things up. This is part of the baggage in beginning-of-defun regarding whether column zero is the beginning of a defun. Changing this now might be unwise, so for the moment I've simply revised the docstring of beginning-of-defun for extra clarity. I've also changed cc-defs.el to use beginning-of-defun-raw, which is a more direct and side-effect free test of beginning-of-defun-function, and added a save-excursion for extra plus safety ;-) [Also, closing bug#636.]