From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andy Stewart Newsgroups: gmane.emacs.devel Subject: Re: Integrate sr-speedbar.el with speedbar.el Date: Sun, 21 Dec 2008 12:49:06 +0800 Message-ID: <87bpv6i14t.fsf@debian.domain> References: <87abasw1wk.fsf@debian.domain> <494DC5CC.7040608@foxmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1229834968 18217 80.91.229.12 (21 Dec 2008 04:49:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 21 Dec 2008 04:49:28 +0000 (UTC) Cc: emacs-devel@gnu.org To: richardeng Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Dec 21 05:50:35 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LEGGv-00087X-RV for ged-emacs-devel@m.gmane.org; Sun, 21 Dec 2008 05:50:34 +0100 Original-Received: from localhost ([127.0.0.1]:39578 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LEGFj-00087v-6D for ged-emacs-devel@m.gmane.org; Sat, 20 Dec 2008 23:49:19 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LEGFd-00087g-Pu for emacs-devel@gnu.org; Sat, 20 Dec 2008 23:49:13 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LEGFd-000870-2f for emacs-devel@gnu.org; Sat, 20 Dec 2008 23:49:13 -0500 Original-Received: from [199.232.76.173] (port=57635 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LEGFd-00086t-02 for emacs-devel@gnu.org; Sat, 20 Dec 2008 23:49:13 -0500 Original-Received: from ti-out-0910.google.com ([209.85.142.190]:31725) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LEGFc-0000qK-BG for emacs-devel@gnu.org; Sat, 20 Dec 2008 23:49:12 -0500 Original-Received: by ti-out-0910.google.com with SMTP id u5so1068437tia.10 for ; Sat, 20 Dec 2008 20:49:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject:references :date:in-reply-to:message-id:user-agent:mime-version:content-type; bh=NMQoqTHWr2Tm1UxsoUy6JDmOSZsL9B4XiQn53zoWbp0=; b=UtDaV9EjnCxm/pN+EM/2HrLHJqyloZSa+QjU+ZPQUeNizm+ax+xSldUotbsUKapDuj wllzIlvbAhJKIOEtV5+eRKV6+vIww/wDGqsSvf43YvQR2CGzEtWcCbtwgznyT5VO6Aci WDYYjOjt4erYkOTt040NVLXfgH3ktveayEnhc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; b=sLllxv1uODT/tDyRRZ3nBCaOCLij/+hYXWXUq2TmSFjvOAFzQuha8omk9MdIngqKgB +8rooLcfwmv0PQaYtT+RGfnoe/CA17z4irtyyKs0TEuTT3ASVqCeg6ErOKT2bZzpsWsD LehxaIPu+W2L+SrsZFG+Az/DMcPn30kSl7iHY= Original-Received: by 10.110.103.5 with SMTP id a5mr7369606tic.45.1229834950738; Sat, 20 Dec 2008 20:49:10 -0800 (PST) Original-Received: from smtp.gmail.com ([222.212.134.169]) by mx.google.com with ESMTPS id b4sm6491373tic.22.2008.12.20.20.49.08 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sat, 20 Dec 2008 20:49:09 -0800 (PST) In-Reply-To: <494DC5CC.7040608@foxmail.com> (richardeng@foxmail.com's message of "Sun, 21 Dec 2008 12:27:56 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:107156 Archived-At: Hi Richard, Thanks for you bug report. About "bug 2", that's my mistake. Now fix it. About "bug 1" and "bug 3", i can't reproducte it. Please send more details step to reproducte it. BTW, send me or "Sebastian Rose" immediately if you find any bug, don't follow this post. Thank you very much! -- Andy richardeng writes: > Andy Stewart wrote: >> Hi all, >> >> Speedbar is very useful for file browser or other programming. >> But this have a big problem is, speedbar is show in other frame. >> So need switch between two frame, not very convenient. >> >> And have a exist extension sr-speedbar.el (write by "Sebastian Rose") >> can make speedbar show in same frame. >> >> Find it at: http://www.emacswiki.org/emacs/download/sr-speedbar.el >> >> I'm another developer of sr-speedbar. >> I have attached newest version of sr-speedbar. >> >> I want to integrate sr-speedbar with speedbar. >> "Sebastian Rose" and me were sign copyright of FSF. >> >> Any suggestion? >> >> -- Andy >> >> > I love this feature, it's useful in console. > > > Bug 1: eval (sr-speedbar-close) twice, then (sr-speedbar-open) got following error: > Window width 0 too small (after splitting) > > So, check sr-speedbar before real closing: ----------------------- > diff -c /tmp/sr-speedbar.el\~ /tmp/sr-speedbar.el --- > /tmp/sr-speedbar.el~ 2008-11-06 07:57:08.000000000 -0800 +++ > /tmp/sr-speedbar.el 2008-11-06 07:59:21.000000000 -0800 @@ > -270,16 +270,17 @@ > (interactive) > (let ((current-window (selected-window))) > (if (and sr-speedbar-window > - speedbar-buffer > - (window-live-p sr-speedbar-window) ;when `sr-speedbar-window' visible > - (buffer-live-p speedbar-buffer)) ;and contain `speedbar-buffer' > - (sr-speedbar-select-window) > - (if (> (current-window-take-width) 1) ;if width of `sr-speedbar-window' is a valid value > - (setq sr-speedbar-width (current-window-take-width))) ;remember it make next restore same > width - (bury-buffer) > - (if (and current-window > - (window-live-p current-window)) > - (select-window current-window))))) > + speedbar-buffer > + (window-live-p sr-speedbar-window) ;when `sr-speedbar-window' visible > + (buffer-live-p speedbar-buffer)) ;and contain `speedbar-buffer' > + (progn > + (sr-speedbar-select-window) > + (if (> (current-window-take-width) 1) ;if width of `sr-speedbar-window' is a valid value > + (setq sr-speedbar-width (current-window-take-width))) ;remember it make next restore > same width + (bury-buffer) > + (if (and current-window > + (window-live-p current-window)) > + (select-window current-window)))))) > > Bug 2: trivial bug > ;;; Installation: ;; > ;; Copy sr-speedbar.el to your load-path and add to your ~/.emacs ;; > ;; (require 'sr-speedbar) ;; > (global-set-key (kbd "s-s") 'sr-speedbar-togge) // --> toggle > ;; ;; ... or any > key binding you like. > > > > Bug 3: (speedbar) then (sr-speedbar-open) report error "Wrong type argument: stringp, nil"