From: Chong Yidong <cyd@gnu.org>
To: emacs-devel@gnu.org
Subject: Re: Inclusion of naquadah-theme
Date: Mon, 25 Jun 2012 21:49:41 +0800 [thread overview]
Message-ID: <87bok7zekq.fsf@gnu.org> (raw)
In-Reply-To: <87pq8nk8cj.fsf@zelenka.enovance.com> (Julien Danjou's message of "Mon, 25 Jun 2012 12:13:16 +0200")
Julien Danjou <julien@danjou.info> writes:
> I'd like to distribute my color theme more widely and therefore include
> it in Emacs distribution. I don't know what the inclusion constraints
> are, so I'm sending this here for review.
>
> http://git.naquadah.org/?p=naquadah-theme.git;a=blob;f=naquadah-theme.el;h=ea9e1b1aba1bac6631e7577e5fc4217ad699d779;hb=HEAD
Please have a better description in the first line than "A color theme",
since this serves as the accompanying text in the M-x customize-themes
buffer. Likewise the docstring to deftheme, which is shown with the
describe-theme command.
Do not set ansi-term-color-vector directly with setq. If you find the
need to customize it, please fix it right: submit a patch to term.el
that converts this to a defcustom, then use custom-theme-set-variables.
Having defuns in a theme file is obnoxious. Could you explain what
these functions are needed for? If there is missing functionality, we
should incorporate that directly into Emacs; they should not be
naquadah-specific.
next prev parent reply other threads:[~2012-06-25 13:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-25 10:13 Inclusion of naquadah-theme Julien Danjou
2012-06-25 13:49 ` Chong Yidong [this message]
2012-06-26 10:48 ` Julien Danjou
2012-06-28 7:36 ` Chong Yidong
2012-06-28 10:42 ` Julien Danjou
2012-06-30 2:15 ` Chong Yidong
2012-07-02 21:02 ` Julien Danjou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bok7zekq.fsf@gnu.org \
--to=cyd@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).