From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: trunk r114048: * src/eval.c (Ffuncall): Fix handling of ((lambda ..) ..) in lexically Date: Fri, 06 Sep 2013 05:00:49 +0300 Message-ID: <87bo46yai6.fsf@yandex.ru> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1378432868 27206 80.91.229.3 (6 Sep 2013 02:01:08 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 6 Sep 2013 02:01:08 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Sep 06 04:01:12 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VHlME-0003ee-9n for ged-emacs-devel@m.gmane.org; Fri, 06 Sep 2013 04:01:10 +0200 Original-Received: from localhost ([::1]:34714 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VHlMD-0004WQ-Tv for ged-emacs-devel@m.gmane.org; Thu, 05 Sep 2013 22:01:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49766) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VHlM6-0004WA-C3 for emacs-devel@gnu.org; Thu, 05 Sep 2013 22:01:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VHlM2-0002of-6I for emacs-devel@gnu.org; Thu, 05 Sep 2013 22:01:02 -0400 Original-Received: from mail-ee0-x232.google.com ([2a00:1450:4013:c00::232]:34524) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VHlM1-0002ob-Vf for emacs-devel@gnu.org; Thu, 05 Sep 2013 22:00:58 -0400 Original-Received: by mail-ee0-f50.google.com with SMTP id d51so1283537eek.9 for ; Thu, 05 Sep 2013 19:00:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=GvgIrirFGyvckpDRjzKydxjFJCNYtEwrYyNj7EwLiHQ=; b=H82Rp4T1RlH9Hl5X9adtKESyUuHutHW2IcIjoBto+hPOuQCm+Ukqxn1Svg7ao3cpL2 H0PcPiaYyldbrjWcqMOLPq+Cn/GBhyqJDZIMl6kxG+iUQR1CS61LB+Z2kp9pEbc+wh3n MGgwwJ7ykd/+4RoCEaIxxZcsBwr5EziJPG7eI5LozlMD/T53/fsPXc7wRh2PBX1gYocy OkoG8tyO4Hc0m0ufh7TXbMq3d2W7iXtnFidusO9/m9iMNspXJXomAD6bwRs1whUIScWE pT1f4ptBAE1CP6Vrts/jNRoksDxgJ/o1u/qJG2M8Ykzn3udUzb7MKNCmWWFhvBCdDVBc uRPg== X-Received: by 10.14.204.5 with SMTP id g5mr82122eeo.110.1378432857069; Thu, 05 Sep 2013 19:00:57 -0700 (PDT) Original-Received: from axl (62-118-214.netrun.cytanet.com.cy. [62.228.118.214]) by mx.google.com with ESMTPSA id a43sm190664eep.9.1969.12.31.16.00.00 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Thu, 05 Sep 2013 19:00:56 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Wed, 28 Aug 2013 18:27:29 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4013:c00::232 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:163208 Archived-At: Hi Stefan, Stefan Monnier writes: > ------------------------------------------------------------ > revno: 114048 > revision-id: monnier@iro.umontreal.ca-20130828182726-uq2hsj7b9v29tk7r > parent: monnier@iro.umontreal.ca-20130828175712-4bbaymrusge69dpg > fixes bug: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11258 This change lowers the performance of the js2-mode parser (which still uses dynamic scoping, by the way) by the factor of five. In interpreted mode, when having this file opened: http://nice-popup.googlecode.com/svn-history/r2/trunk/mootools-core-1.3-full-nocompat.js Evaluating (js2-time (js2-reparse t)) Shows 0.9s before this revision and some 4.7s after it. Incidentally, the slowdown factor is similar to I've seen when trying to measure its performance in lexical-binding mode before this revision. pre-114048, lexical-binding: t -- 3.95 seconds 114048+, lexical-binding: t -- 7-8 seconds Should I file a dedicated bug?