From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Kastrup Newsgroups: gmane.emacs.devel Subject: Re: master 5022e27: ; Do not overwrite preexisting contents of unread-command-events Date: Sat, 08 Aug 2015 17:04:31 +0200 Message-ID: <87bnehizy8.fsf@fencepost.gnu.org> References: <20150804124300.13374.78396@vcs.savannah.gnu.org> <2qy4hr840o.fsf@fencepost.gnu.org> <87r3nj3vbw.fsf@fencepost.gnu.org> <87k2t6i3hu.fsf@fencepost.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1439047644 15791 80.91.229.3 (8 Aug 2015 15:27:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 8 Aug 2015 15:27:24 +0000 (UTC) Cc: Glenn Morris , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Aug 08 17:27:23 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZO61o-0002jB-Vp for ged-emacs-devel@m.gmane.org; Sat, 08 Aug 2015 17:27:21 +0200 Original-Received: from localhost ([::1]:53101 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZO61j-0006QS-8a for ged-emacs-devel@m.gmane.org; Sat, 08 Aug 2015 11:27:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34344) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZO61R-0006NC-Ns for emacs-devel@gnu.org; Sat, 08 Aug 2015 11:26:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZO61Q-00060a-QD for emacs-devel@gnu.org; Sat, 08 Aug 2015 11:26:57 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:48460) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZO61Q-00060W-Nq; Sat, 08 Aug 2015 11:26:56 -0400 Original-Received: from localhost ([127.0.0.1]:34043 helo=lola) by fencepost.gnu.org with esmtp (Exim 4.82) (envelope-from ) id 1ZO61P-00047n-VM; Sat, 08 Aug 2015 11:26:56 -0400 Original-Received: by lola (Postfix, from userid 1000) id B1044E0C0D; Sat, 8 Aug 2015 17:04:31 +0200 (CEST) In-Reply-To: (Stefan Monnier's message of "Sat, 08 Aug 2015 10:17:15 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:188616 Archived-At: Stefan Monnier writes: >>>> Surely this change deserved to create a ChangeLog entry, rather than >>>> being marked with "; " to exclude that. >>> A ChangeLog entry would run over several dozens of lines and take the >>> better part of an hour to create since C-x v a does not work with Git. >>> I=A0figured that nobody would even notice anyway. > > I think what Glenn said, was that the entry should not have started > with ";". That would have generated a sub-optimal ChangeLog entry, > but that's better than no ChangeLog entry. Let me make very clear that I looked at CONTRIBUTE first and finally went by - Start with a single unindented summary line explaining the change; do not end this line with a period. If that line starts with a semi-colon and a space "; ", the log message will be ignored when generating the ChangeLog file. Use this for minor commits that do not need separate ChangeLog entries, such as changes in etc/NEWS. since the only listed alternative was a full GNU-style ChangeLog commit message. Without looking at CONTRIBUTE, I would have written up a commit message like I do on other projects, _not_ listing every filename and function name (which are listed in the accompanying context diff "git log -p" produces). That would have been little work and would have made every bit of information readily accessible that one would want. I was not sure that the ChengeLog-entry free variant was really the best choice. That's one of the reason I posted the patch for comment on the Emacs-devel list. I'll prepare a ChangeLog entry like Eli described and commit it. I=A0really cannot imagine that it will be useful ever to anybody as the collection of function names and affected files is a rather random assortment (I could not name a single one in spite of creating the patch). So I skipped out on work I could not imagine anyone to want. I=A0was wrong on that but in my defense I did solicit for feedback. --=20 David Kastrup