From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: phillip.lord@russet.org.uk (Phillip Lord) Newsgroups: gmane.emacs.devel Subject: Re: Calling Lisp from undo.c's record_* functions Date: Sun, 22 Nov 2015 21:44:30 +0000 Message-ID: <87bnalwvy9.fsf@russet.org.uk> References: <83r3jpc2of.fsf@gnu.org> <87h9kkbz6k.fsf@russet.org.uk> <838u5wbmvu.fsf@gnu.org> <83ziyc9zs0.fsf@gnu.org> <83wptg9dcd.fsf@gnu.org> <87610zsd3u.fsf@russet.org.uk> <83io4z9ozx.fsf@gnu.org> <87wpte8fas.fsf@russet.org.uk> <83poz67zpd.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1448230236 19913 80.91.229.3 (22 Nov 2015 22:10:36 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 22 Nov 2015 22:10:36 +0000 (UTC) Cc: monnier@IRO.UMontreal.CA, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Nov 22 23:10:23 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a0cpx-0006Cc-NM for ged-emacs-devel@m.gmane.org; Sun, 22 Nov 2015 23:10:21 +0100 Original-Received: from localhost ([::1]:57690 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0cpx-0005g4-RW for ged-emacs-devel@m.gmane.org; Sun, 22 Nov 2015 17:10:21 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43372) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0cpu-0005fH-N3 for emacs-devel@gnu.org; Sun, 22 Nov 2015 17:10:19 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a0cpt-0001B4-NV for emacs-devel@gnu.org; Sun, 22 Nov 2015 17:10:18 -0500 Original-Received: from cheviot22.ncl.ac.uk ([128.240.234.22]:37837) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0cpp-000165-Rj; Sun, 22 Nov 2015 17:10:13 -0500 Original-Received: from smtpauth-vm.ncl.ac.uk ([10.8.233.129] helo=smtpauth.ncl.ac.uk) by cheviot22.ncl.ac.uk with esmtp (Exim 4.63) (envelope-from ) id 1a0cpm-0004jE-Dx; Sun, 22 Nov 2015 22:10:10 +0000 Original-Received: from cpc6-benw10-2-0-cust45.gate.cable.virginm.net ([92.238.179.46] helo=localhost) by smtpauth.ncl.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63) (envelope-from ) id 1a0cpm-0005ce-0R; Sun, 22 Nov 2015 22:10:10 +0000 In-Reply-To: <83poz67zpd.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 19 Nov 2015 17:53:34 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 128.240.234.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:195075 Archived-At: Eli Zaretskii writes: >> Can you test this branch for me, and see if you can reproduce the error. >> >> fix/segfault-undoable-change-prepare-for-buffer >> >> This leaves the implementation as was, but moves the run_undoable_change >> call to prepare_for_change_1. > > I will try, but I don't see the need to delay installing these > changes, if the reason is the need to wait for me to run a bootstrap, > since I believe you've found a way to reproduce the original problem > on your system. I'll merge this in tomorrow hopefully. Just to check I have this correct, now that we have feature freeze, I should merge (or rebase) to the emacs-25 branch? And, then I have to cherry pick this across to master? Or the other way around? Or does it not matter? Phil