From: phillip.lord@russet.org.uk (Phillip Lord)
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] fix/undo-point-in-wrong-place 6b3cfe4 4/4: Prepare for record now separate function.
Date: Thu, 26 Nov 2015 10:32:53 +0000 [thread overview]
Message-ID: <87bnahaw4q.fsf@russet.org.uk> (raw)
In-Reply-To: <jwv37vtv2c5.fsf-monnier+emacsdiffs@gnu.org> (Stefan Monnier's message of "Wed, 25 Nov 2015 23:00:35 -0500")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> Does this seem a reasonable solution (I've used the idea behind your
>> patch, but with variables that already exist in keyboard.c)?
>
> As pointed out in the reply to the actual commit-diff,
Sorry, I think I missed that one.
> the new code has another problem: it always uses the "point at
> beginning of command", which is usually right but not when an
> undo-boundary was pushed between "beginning of command" and the moment
> when we try to record point.
I really should stop thinking for myself and just do what I am told.
I've pushed a new version.
Phil
next prev parent reply other threads:[~2015-11-26 10:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20151120221320.21643.45342@vcs.savannah.gnu.org>
[not found] ` <E1Zztvo-0005ey-0X@vcs.savannah.gnu.org>
2015-11-22 5:21 ` [Emacs-diffs] fix/undo-point-in-wrong-place 6b3cfe4 4/4: Prepare for record now separate function Stefan Monnier
2015-11-23 17:41 ` Phillip Lord
2015-11-25 22:46 ` Phillip Lord
2015-11-26 4:00 ` Stefan Monnier
2015-11-26 10:32 ` Phillip Lord [this message]
2015-11-26 15:56 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bnahaw4q.fsf@russet.org.uk \
--to=phillip.lord@russet.org.uk \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).