From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: wait_reading_process_ouput hangs in certain cases (w/ patches) Date: Tue, 13 Mar 2018 17:57:17 +0100 Message-ID: <87bmfrc3rm.fsf@gmail.com> References: <7550438b-9fd4-d374-e571-8bb16456cad5@cs.ucla.edu> <797d0e16-1bae-50c2-35f8-05489ffce935@binary-island.eu> <83tvugdiu5.fsf@gnu.org> <877er5s0xv.fsf@gmail.com> <4e4c72bb-295d-81e1-e4ed-cad256bca83c@binary-island.eu> <87zi3v9461.fsf@gmail.com> <87k1uy8x68.fsf@gmail.com> <6d1970af-8c5c-20ba-be09-0b9aa757d663@binary-island.eu> <13b3e003-d12b-33a7-3ebe-c07b017a7cc0@binary-island.eu> <87r2oow3uc.fsf@gmail.com> <2ab717c8-8d4f-ff34-04db-63b1c8b83dd4@yandex.ru> <87muzcasho.fsf@gmail.com> <4c9d1e14-440d-580c-ad93-ca3e6936c366@yandex.ru> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1520962843 20002 195.159.176.226 (13 Mar 2018 17:40:43 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 13 Mar 2018 17:40:43 +0000 (UTC) Cc: emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 13 18:40:39 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1evnua-0004xJ-Sh for ged-emacs-devel@m.gmane.org; Tue, 13 Mar 2018 18:40:32 +0100 Original-Received: from localhost ([::1]:41565 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1evnwd-0006P2-TD for ged-emacs-devel@m.gmane.org; Tue, 13 Mar 2018 13:42:40 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43265) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1evnEr-0001qp-PS for emacs-devel@gnu.org; Tue, 13 Mar 2018 12:57:26 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1evnEn-0005Hp-RC for emacs-devel@gnu.org; Tue, 13 Mar 2018 12:57:25 -0400 Original-Received: from mail-wr0-x235.google.com ([2a00:1450:400c:c0c::235]:34154) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1evnEn-0005HD-Kx for emacs-devel@gnu.org; Tue, 13 Mar 2018 12:57:21 -0400 Original-Received: by mail-wr0-x235.google.com with SMTP id o8so896891wra.1 for ; Tue, 13 Mar 2018 09:57:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:mail-followup-to:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:mime-version; bh=3Eh4mAAywoN/Ein1TGjF0+i9j8tWsOlkhIBn9fU9JTA=; b=gm5ywDFDfGbG9NhL1g72TYuLyl6HtARLl8R0j58aHB12m3XWp4KRJuZ3IJmuO0MclP RTFfK9RJVv8kk1vghMyTw0HagHRXwnFWwAOM4LDafaaEdfEY/7QU+1oGjijBp93JSKgM mv/atsQW1kaLqVEoPtBBICuKnD84sNF9zhjT7xft9mtP/jZWRhZj/S/YraA/1fduP4I4 e4cEJ2jOhhP6UZrFXOuSlTrWa7nIHgZwl+qmUOV263PuMkfU+fBNRCn6Z8KyNVP8pHPS nnuQbgKopLBFmS1EqCojBANeMZQzxvzKC0Sdn3DbWCflOhU90PBOL7jzYwvTT2H/ETBO KNhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:mail-followup-to :mail-copies-to:gmane-reply-to-list:date:in-reply-to:message-id :mime-version; bh=3Eh4mAAywoN/Ein1TGjF0+i9j8tWsOlkhIBn9fU9JTA=; b=Gch7T3jrajGtc1W9Ot9XCRBN7h4rG5YRNLut+zgYIuBY1w2kUgddP+bC7NzNPwCiAn yUL75W0HHHwHCJhiroyDdW1aAXM+AoxKl3Okql893JNrOQD+D8/RjKiUrLAOYh4wt4hm Cy31gh+5Z2Z+NQGu4mC1HsprU5hgq4Mv9Czg70Qz4j/vayX4pCeNS7zceG8iHCT5mwxe YvqrVvZcZ1QTfqLzNVoxaXiUCDeOLBUVmWOqSvcR4zGQ5FtxnHboZVyYK6S1lhtgjNGK zU2tyC5psH4qOBiB1uwSEaegN/YXtsVZdKftM4cXVbltHcNEIhXf4tSt5j02p90ZFIBZ dEpQ== X-Gm-Message-State: AElRT7Eq8I4k02J92ir79v4odqbF68nEJEpC0vdLx6xbABaEaZKGTzbU uAxVF+PIPbSndz1EtolS0Ohs7X2pmY4= X-Google-Smtp-Source: AG47ELu6K5HNoPol5ntZES9DngubfUC7seNEY97NJZETjyfwsZZOLVabrc7pSrmR/67wvue+vcjKQA== X-Received: by 10.28.29.209 with SMTP id d200mr1416266wmd.149.1520960240083; Tue, 13 Mar 2018 09:57:20 -0700 (PDT) Original-Received: from rpluim-ubuntu ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id c14sm739095wrd.17.2018.03.13.09.57.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Mar 2018 09:57:19 -0700 (PDT) Mail-Followup-To: emacs-devel@gnu.org Mail-Copies-To: never Gmane-Reply-To-List: yes In-Reply-To: <4c9d1e14-440d-580c-ad93-ca3e6936c366@yandex.ru> (Dmitry Gutov's message of "Tue, 13 Mar 2018 17:56:17 +0200") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::235 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:223701 Archived-At: Dmitry Gutov writes: > On 3/13/18 5:46 PM, Robert Pluim wrote: > >> It got caught before it got committed, so not that bad. > > I mean the general possibility of having somebody who comes later > reverse the fix. > > For some code the odds of this happening are fairly small (via > architectural decisions, or segregating a fix into a separate unit of > code, or maybe just commenting profusely). Not so in this case, > apparently. As Eli has pointed out, it's a very fiddly area to work in. >>> Fiddly, hard-to-reproduce misbehavior is the ideal target for >>> regression tests, IMO. >> >> My current test-case for 21337 is 'visit a bunch of files, make sure >> global-auto-revert is turned on and auto-revert-use-notify is t, run >> Gnus (or anything else that makes TLS connections), wait for errors to >> be signalled by inotify'. I don't know how to write a regression test >> for that. > > Maybe there's a way to simulate the critical conditions more directly? It has to involve TLS and reading from TLS connections. I don't think we want emacs' regression tests to be making connections to servers on the internet. I've never tried to use 'make-network-process' to create a TLS server in emacs, but perhaps that could be used instead. Robert