From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: Text property searching Date: Mon, 16 Apr 2018 23:18:54 +0200 Message-ID: <87bmeivoht.fsf@mouse.gnus.org> References: <87lgdo5bb3.fsf@mouse.gnus.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1523913448 730 195.159.176.226 (16 Apr 2018 21:17:28 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 16 Apr 2018 21:17:28 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Apr 16 23:17:24 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f8BV6-0008Tn-72 for ged-emacs-devel@m.gmane.org; Mon, 16 Apr 2018 23:17:24 +0200 Original-Received: from localhost ([::1]:44553 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f8BXC-0007WD-Tq for ged-emacs-devel@m.gmane.org; Mon, 16 Apr 2018 17:19:34 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50254) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f8BX3-0007VY-2y for emacs-devel@gnu.org; Mon, 16 Apr 2018 17:19:26 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f8BWz-0005YS-Sr for emacs-devel@gnu.org; Mon, 16 Apr 2018 17:19:25 -0400 Original-Received: from hermes.netfonds.no ([80.91.224.195]:47112) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f8BWz-0005Vl-LJ for emacs-devel@gnu.org; Mon, 16 Apr 2018 17:19:21 -0400 Original-Received: from 46.67.12.60.tmi.telenormobil.no ([46.67.12.60] helo=corrigan) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1f8BWv-00074O-Dm; Mon, 16 Apr 2018 23:19:19 +0200 Original-Received: from larsi by corrigan with local (Exim 4.89) (envelope-from ) id 1f8BWZ-00089m-IO; Mon, 16 Apr 2018 23:18:55 +0200 In-Reply-To: (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vora=22's?= message of "Mon, 16 Apr 2018 16:16:01 +0100") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 80.91.224.195 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:224686 Archived-At: Jo=C3=A3o T=C3=A1vora writes: > 1. What should happen if search starts in the region where the > property is already set? I've reconsidered slightly after rewriting a couple of functions to use this. A typical use case is the user hitting TAB to go to the next button in a buffer. That would then be something like (when (get-text-property (point) 'shr-url) (text-property-search-forward 'shr-url nil t)) (text-property-search-forward 'shr-url nil nil) I mean, it's not awful, but it's a common use case, and that's boring to have to type. So I added a flag, and you can now skip matches under point. This function: (defun shr-next-link () "Skip to the next link." (interactive) (let ((current (get-text-property (point) 'shr-url)) (start (point)) skip) (while (and (not (eobp)) (equal (get-text-property (point) 'shr-url) current)) (forward-char 1)) (cond ((and (not (eobp)) (get-text-property (point) 'shr-url)) ;; The next link is adjacent. (message "%s" (get-text-property (point) 'help-echo))) ((or (eobp) (not (setq skip (text-property-not-all (point) (point-max) 'shr-url nil)))) (goto-char start) (message "No next link")) (t (goto-char skip) (message "%s" (get-text-property (point) 'help-echo)))))) Can now be rewritten as: (defun shr-next-link () "Skip to the next link." (interactive) (if (not (text-property-search-forward 'shr-url nil nil t)) (message "No next link") (message "%s" (get-text-property (point) 'help-echo)))) :-) --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no