From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tom Tromey Newsgroups: gmane.emacs.devel Subject: Re: Making 'eq' == 'eql' in bignum branch Date: Sun, 26 Aug 2018 10:34:21 -0600 Message-ID: <87bm9pytma.fsf@tromey.com> References: <29f933ac-a6bf-8742-66a7-0a9d6d3e5a88@disroot.org> <8e0320d9-e0d0-2b57-57cc-2df4399f133c@cs.ucla.edu> <87lgaio7xd.fsf@tromey.com> <877em1cb0i.fsf@tromey.com> <765767b2-d2e5-a9a6-f724-d58ecf4847bb@cs.ucla.edu> <76081b5d-8c10-0a37-2c97-d4864c0faa80@cs.ucla.edu> <09153aed-361d-4f82-d9ac-b502314769ae@cs.ucla.edu> <83lg91dqd4.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1535301232 32034 195.159.176.226 (26 Aug 2018 16:33:52 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 26 Aug 2018 16:33:52 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) Cc: rms@gnu.org, emacs-devel@gnu.org, monnier@iro.umontreal.ca, pipcet@gmail.com, Lars Ingebrigtsen , eliz@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Aug 26 18:33:47 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ftxz0-0008Bw-El for ged-emacs-devel@m.gmane.org; Sun, 26 Aug 2018 18:33:47 +0200 Original-Received: from localhost ([::1]:49694 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fty16-00019Z-Ea for ged-emacs-devel@m.gmane.org; Sun, 26 Aug 2018 12:35:56 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36627) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ftxzg-0000WU-39 for emacs-devel@gnu.org; Sun, 26 Aug 2018 12:34:28 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ftxzc-0004xT-RX for emacs-devel@gnu.org; Sun, 26 Aug 2018 12:34:28 -0400 Original-Received: from gateway21.websitewelcome.com ([192.185.45.147]:12512) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ftxzc-0004wg-D0 for emacs-devel@gnu.org; Sun, 26 Aug 2018 12:34:24 -0400 Original-Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway21.websitewelcome.com (Postfix) with ESMTP id 41871400C52DC for ; Sun, 26 Aug 2018 11:34:23 -0500 (CDT) Original-Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id txzbfSFr179N3txzbfhBFz; Sun, 26 Aug 2018 11:34:23 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=oQdyrWRfa1piyniaDLc7UTZZyugRnC8xb+1uplFh/1M=; b=s+3WRiU5fC7OrxkjS1zMEWfwwe C12W4kQI3LY5yt51EGzGw1OS2EFR64SEMb7gkgW2Opq2JwOq04O1myVmfa1NI9T3v2yIJUglyUW5/ xvL2xrU4MCroThNvbsphSgGAn; Original-Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:60674 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1ftxza-000Gxo-Ri; Sun, 26 Aug 2018 11:34:22 -0500 X-Attribution: Tom In-Reply-To: (Paul Eggert's message of "Sat, 25 Aug 2018 16:27:20 -0700") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.85.72 X-Source-L: No X-Exim-ID: 1ftxza-000Gxo-Ri X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-85-72.hlrn.qwest.net (bapiya) [75.166.85.72]:60674 X-Source-Auth: tom+tromey.com X-Email-Count: 8 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 192.185.45.147 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:228939 Archived-At: >>>>> "Paul" == Paul Eggert writes: Paul> * Several modules assumes that buffer sizes fits into fixnums. This Paul> assumption is correct for Emacs master, though it will become dubious Paul> if we change Emacs to support buffer sizes greater than Paul> most-positive-fixnum. The affected modules are emacs-lisp/syntax.el, Paul> org/org-list.el, progmodes/cc-engine.el, progmodes/js.el, and Paul> simple.el. The js.el uses fall into 2 categories. One, assuming the maximum paren depth is most-positive-fixnum: (defconst js--initial-pitem (make-js--pitem :paren-depth most-negative-fixnum :type 'toplevel)) This seems reasonably safe. You'd need a truly absurd .js file to break this. Two, as an argument to forward-comment: (forward-comment most-positive-fixnum). This also seems safe, as the argument is a comment count, not a buffer position. That said these could perhaps be changed to (forward-comment (point-max)). Tom