From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Alex Gramiak Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] * configure.ac: Avoid gnulib's test for pthread_sigmask Date: Thu, 02 May 2019 23:48:06 -0600 Message-ID: <87bm0kks15.fsf@gmail.com> References: <8736lwmp2h.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="31215"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) Cc: emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri May 03 23:20:48 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hMfbp-0017On-Fd for ged-emacs-devel@m.gmane.org; Fri, 03 May 2019 23:20:45 +0200 Original-Received: from localhost ([127.0.0.1]:34880 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMR3W-0003TS-7H for ged-emacs-devel@m.gmane.org; Fri, 03 May 2019 01:48:22 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:53467) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMR3H-0003RX-04 for emacs-devel@gnu.org; Fri, 03 May 2019 01:48:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hMR3E-00074k-2E for emacs-devel@gnu.org; Fri, 03 May 2019 01:48:06 -0400 Original-Received: from mail-pf1-x429.google.com ([2607:f8b0:4864:20::429]:35314) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hMR3D-00074Q-QI for emacs-devel@gnu.org; Fri, 03 May 2019 01:48:04 -0400 Original-Received: by mail-pf1-x429.google.com with SMTP id t87so1762923pfa.2 for ; Thu, 02 May 2019 22:48:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=XsJtav/bQ5HCYrGKk9iSn4xWEIRa4fshulmacbVqaYs=; b=jnLAzssXbHmSPRDGtZP8WKoB8bECaVXI1IwPjHlRfftYfanzohoH18xpPsofMhBBmR cWGzG1m0xuZt7CKfc5eRfZZwy+QxhDLaJuCl/rVxW0nV20D885T2D04LBOpuodPXI+Ho /4K3ToZRqJewjFDQWE8bhUaRtLGpFhJPaUOup1mx0G7tQhZVs42AlFFtdhpnDA9XcI0D 01/isEG9c/x32ZI+jcU2/Gy4bXhUAQC4WyLMQb62xMZIa6nTXaDMuvL1G8oPK0YehTUh 9u9yf4OZ/maaYbwB8JnrpgxyWulHS/n66rpiqmQUxwY4d97Q8G4yeCArpcziLyPe0wuA d+8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=XsJtav/bQ5HCYrGKk9iSn4xWEIRa4fshulmacbVqaYs=; b=D14caPJku2sE1IEQhGvVPK9abWVfiU2+dqnfbhzwNZv0DmmGcZjSU1TcsIhkqSmOJU svqGHsNjSEJUnobS7EsSOAXone1+aMAmFIjCs2cmGFQJMZpUPVyDcPcGzKKanGKXHPO1 cGBI0aQKYm9y+6m0bXYpaOKvqJTIE9dnpoGeLzKJZaWHFZWlIGaSWzl+5a+JFSXtqPN0 qPVJfiTNvRNnXr3Cs18jp7KXh39Tf+GudxqZLAAwPeRCREfvXuoCulL+sXe46Wk1zEwz bAgHAVitYECYYFH9b6HWndl9Vi9s0+nge8XRZEBdv4eP29TCjDp+lnKs0SiKTM09LtpV jgnQ== X-Gm-Message-State: APjAAAWBBWgAiytw2efl6wacYB0IkIPTqJhvU5al1YLIkT35RJQuDM8b mSuZqnZ67T8xjEiHn5qB7MnwwIwB X-Google-Smtp-Source: APXvYqxMz7JIshvMS3T/GN2HjwPGG07qws/NIAIh5Pbel42aQpeRTXDY7bjjW4ZO/0+t/wGqj362MA== X-Received: by 2002:a62:d205:: with SMTP id c5mr8439278pfg.219.1556862482582; Thu, 02 May 2019 22:48:02 -0700 (PDT) Original-Received: from lylat ([2604:3d09:e37f:1500:1a72:4878:e793:7302]) by smtp.gmail.com with ESMTPSA id t7sm251582pfa.42.2019.05.02.22.48.01 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 02 May 2019 22:48:01 -0700 (PDT) In-Reply-To: (Paul Eggert's message of "Thu, 2 May 2019 17:42:28 -0700") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::429 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236132 Archived-At: Paul Eggert writes: > On 5/2/19 4:09 PM, Alex Gramiak wrote: >> The nearby comment states "Avoid gnulib's test for pthread_sigmask", but >> the method used doesn't seem to work. >> >> What I see is that gl_INIT is called, which calls >> gl_FUNC_PTHREAD_SIGMASK. > > It what sense is it not working? gl_FUNC_PTHREAD_SIGMASK is not the same > as "gnulib's test for pthread_sigmask", so the comment is not > contradicted by the fact that gl_INIT calls gl_FUNC_PTHREAD_SIGMASK. Ah, I get it now; it's referring to the AC_CHECK_FUNCS_ONCE in pthread_sigmask.m4 rather than the tests for pthread_sigmask functionality. Is there a reason to test for it in configure.ac instead of in pthread_sigmask.m4? I would think that it makes sense to use gnulib's version since it uses AC_CHECK_FUNCS_ONCE over AC_CHECK_FUNCS. > The latter macro does some useful sanity checking on platforms where > pthread_sigmask exists but doesn't do anything, e.g., on Solaris 11 > Update 3 or older if you don't define _REENTRANT then Emacs's > pthreaded code will likely fail in subtle ways (see > ). Thanks, I understand now. However, considering that the pthread_sigmask tests are relatively slow, is there an easy way to specify some common platforms that don't have this problem so that they can skip the tests?