From: Alex Gramiak <agrambot@gmail.com>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] * configure.ac: Avoid gnulib's test for pthread_sigmask
Date: Thu, 02 May 2019 23:48:06 -0600 [thread overview]
Message-ID: <87bm0kks15.fsf@gmail.com> (raw)
In-Reply-To: <c11764d0-175e-ae2c-ff8d-a0a28a4d8cc5@cs.ucla.edu> (Paul Eggert's message of "Thu, 2 May 2019 17:42:28 -0700")
Paul Eggert <eggert@cs.ucla.edu> writes:
> On 5/2/19 4:09 PM, Alex Gramiak wrote:
>> The nearby comment states "Avoid gnulib's test for pthread_sigmask", but
>> the method used doesn't seem to work.
>>
>> What I see is that gl_INIT is called, which calls
>> gl_FUNC_PTHREAD_SIGMASK.
>
> It what sense is it not working? gl_FUNC_PTHREAD_SIGMASK is not the same
> as "gnulib's test for pthread_sigmask", so the comment is not
> contradicted by the fact that gl_INIT calls gl_FUNC_PTHREAD_SIGMASK.
Ah, I get it now; it's referring to the AC_CHECK_FUNCS_ONCE in
pthread_sigmask.m4 rather than the tests for pthread_sigmask
functionality.
Is there a reason to test for it in configure.ac instead of in
pthread_sigmask.m4? I would think that it makes sense to use gnulib's
version since it uses AC_CHECK_FUNCS_ONCE over AC_CHECK_FUNCS.
> The latter macro does some useful sanity checking on platforms where
> pthread_sigmask exists but doesn't do anything, e.g., on Solaris 11
> Update 3 or older if you don't define _REENTRANT then Emacs's
> pthreaded code will likely fail in subtle ways (see
> <https://blogs.oracle.com/solaris/mtreentrant-v2>).
Thanks, I understand now. However, considering that the pthread_sigmask
tests are relatively slow, is there an easy way to specify some common
platforms that don't have this problem so that they can skip the tests?
prev parent reply other threads:[~2019-05-03 5:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-02 23:09 [PATCH] * configure.ac: Avoid gnulib's test for pthread_sigmask Alex Gramiak
2019-05-03 0:42 ` Paul Eggert
2019-05-03 5:48 ` Alex Gramiak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bm0kks15.fsf@gmail.com \
--to=agrambot@gmail.com \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).