From: Juri Linkov <juri@linkov.net>
To: emacs-devel@gnu.org
Subject: Re: search-default-mode char-fold-to-regexp and Greek Extended block characters
Date: Thu, 25 Jul 2019 02:12:01 +0300 [thread overview]
Message-ID: <87blxj3u4e.fsf@mail.linkov.net> (raw)
In-Reply-To: <m2muh3n6qk.fsf@gmail.com> (Robert Pluim's message of "Wed, 24 Jul 2019 11:04:35 +0200")
> >> Done as f9337bc36d
> Juri> Thanks! Could you please look why tests fail to validate matching of
> Juri> n-level decomposition. The character with 3 level decomposition in
> Juri> char-fold--test-without-customization is currently commented out as
> Juri> FIXME. After uncommenting this test fails, and I don't understand why.
>
> That test ends up doing
>
> (string-match "\\`\\(?:ι[̀́̄̆̈̓̔͂]\\|[ΐίιϊἰ-ἷὶίιῐ-ΐῖῗ𝛊𝜄𝜾𝝸𝞲]\\)\\'" "Ϊ́")
>
> because it does (upcase "ΐ") => Ϊ́
>
> That character is GREEK SMALL LETTER IOTA WITH DIALYTIKA AND OXIA, and
> as far as I can tell there is no CAPITAL variant of that letter, so
> upcase canʼt return it, which means it returns GREEK CAPITAL LETTER
> IOTA plus the diacriticals, which is obviously not going to
> match.
This is an interesting case like (upcase "ß") => "SS" that required
adding (?ß "ss") to pass the tests. So I guess we need to add (?ι "ΐ")
for the tests to pass:
diff --git a/test/lisp/char-fold-tests.el b/test/lisp/char-fold-tests.el
index e519435ef0..3819f3919d 100644
--- a/test/lisp/char-fold-tests.el
+++ b/test/lisp/char-fold-tests.el
@@ -166,6 +165,7 @@ char-fold--test-with-customization
(let* ((char-fold-include
'(
(?ß "ss") ;; de
+ (?ι "ΐ") ;; el
(?o "ø") ;; da no nb nn
(?l "ł") ;; pl
))
@@ -184,9 +184,7 @@ char-fold--test-with-customization
'(
("e" "ℯ" "ḗ" "ë" "ë")
("е" "ё" "ё")
- ("ι" "ί" "ί"
- ;; FIXME: "ΐ"
- )
+ ("ι" "ί" "ί" "ΐ")
("ß" "ss")
("o" "ø")
("l" "ł")
But this is only for char-fold--test-with-customization. OTOH, for
char-fold--test-without-customization we need also to change the default
value in char-fold.el like:
diff --git a/lisp/char-fold.el b/lisp/char-fold.el
index f379229e6c..c4add03bd9 100644
--- a/lisp/char-fold.el
+++ b/lisp/char-fold.el
@@ -27,7 +27,8 @@
(defconst char-fold--default-include
'((?\" """ "“" "”" "”" "„" "⹂" "〞" "‟" "‟" "❞" "❝" "❠" "“" "„" "〝" "〟" "🙷" "🙶" "🙸" "«" "»")
(?' "❟" "❛" "❜" "‘" "’" "‚" "‛" "‚" "" "❮" "❯" "‹" "›")
- (?` "❛" "‘" "‛" "" "❮" "‹")))
+ (?` "❛" "‘" "‛" "" "❮" "‹")
+ (?ι "ΐ")))
(defconst char-fold--default-exclude nil)
(defconst char-fold--default-symmetric nil)
(defconst char-fold--previous (list char-fold--default-include
diff --git a/test/lisp/char-fold-tests.el b/test/lisp/char-fold-tests.el
index e519435ef0..3819f3919d 100644
--- a/test/lisp/char-fold-tests.el
+++ b/test/lisp/char-fold-tests.el
@@ -154,8 +154,7 @@ char-fold--test-without-customization
("ι"
"ί" ;; 1 level decomposition
"ί" ;; 2 level decomposition
- ;; FIXME:
- ;; "ΐ" ;; 3 level decomposition
+ "ΐ" ;; 3 level decomposition
)
)))
(dolist (strings matches)
next prev parent reply other threads:[~2019-07-24 23:12 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-19 14:18 search-default-mode char-fold-to-regexp and Greek Extended block characters Robert Pluim
2019-07-19 14:37 ` Eli Zaretskii
2019-07-19 16:03 ` Robert Pluim
2019-07-19 18:13 ` Eli Zaretskii
2019-07-21 11:03 ` Robert Pluim
2019-07-22 18:39 ` Robert Pluim
2019-07-23 14:57 ` Eli Zaretskii
2019-07-23 17:43 ` Robert Pluim
2019-07-23 20:29 ` Juri Linkov
2019-07-24 7:56 ` Robert Pluim
2019-07-24 7:59 ` Robert Pluim
2019-07-24 9:04 ` Robert Pluim
2019-07-24 23:12 ` Juri Linkov [this message]
2019-07-25 0:18 ` Basil L. Contovounesios
2019-07-25 18:40 ` Juri Linkov
2019-07-25 20:44 ` search-default-mode char-fold-to-regexp and Greek Extended block characters, " Robert Pluim
2019-07-25 21:35 ` Juri Linkov
2019-07-26 11:09 ` Robert Pluim
2019-07-26 18:38 ` Juri Linkov
2019-07-29 8:32 ` Robert Pluim
2019-07-29 18:09 ` Juri Linkov
2019-07-30 8:09 ` Robert Pluim
2019-07-30 10:15 ` Eli Zaretskii
2019-07-25 2:36 ` Eli Zaretskii
2019-07-25 8:59 ` Robert Pluim
2019-07-25 12:53 ` Eli Zaretskii
2019-07-25 8:46 ` Robert Pluim
2019-07-25 18:46 ` Juri Linkov
2019-07-26 6:04 ` Eli Zaretskii
2019-07-26 18:40 ` Juri Linkov
2019-07-26 19:13 ` Eli Zaretskii
2019-07-19 18:53 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87blxj3u4e.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).