From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Enable persistent naming for tabs Date: Thu, 10 Oct 2019 01:58:31 +0300 Organization: LINKOV.NET Message-ID: <87blup8r1k.fsf@mail.linkov.net> References: <87d0f66fi5.fsf@cochranmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="176138"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: emacs-devel@gnu.org To: Robert Cochran Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Oct 10 01:06:57 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iIL2n-000jfO-GS for ged-emacs-devel@m.gmane.org; Thu, 10 Oct 2019 01:06:57 +0200 Original-Received: from localhost ([::1]:60780 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIL2l-0001qx-R9 for ged-emacs-devel@m.gmane.org; Wed, 09 Oct 2019 19:06:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:32990) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIKyf-0006A8-QG for emacs-devel@gnu.org; Wed, 09 Oct 2019 19:02:43 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iIKye-0001YA-CN for emacs-devel@gnu.org; Wed, 09 Oct 2019 19:02:41 -0400 Original-Received: from crocodile.birch.relay.mailchannels.net ([23.83.209.45]:50154) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iIKyd-0001X6-NP for emacs-devel@gnu.org; Wed, 09 Oct 2019 19:02:40 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id C6B1C1A1219; Wed, 9 Oct 2019 23:02:36 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a88.g.dreamhost.com (100-96-6-135.trex.outbound.svc.cluster.local [100.96.6.135]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 540671A124D; Wed, 9 Oct 2019 23:02:36 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a88.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.5); Wed, 09 Oct 2019 23:02:36 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Absorbed-Gusty: 793f62e57632ab0d_1570662156567_978975403 X-MC-Loop-Signature: 1570662156567:1849336681 X-MC-Ingress-Time: 1570662156567 Original-Received: from pdx1-sub0-mail-a88.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a88.g.dreamhost.com (Postfix) with ESMTP id 6C31C8139E; Wed, 9 Oct 2019 16:02:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=10UGoPysKBlKFk99JBSNt5g/KEQ=; b= EU9xCUdNCVSFJCvJCTE1c8yzRtNVec0DqrNNsrZ8pCVWVEoRe03HZV9jX1IXl5F/ bdABPCvcOZsJ86JzDNM+/O4Whr1UODD0PXi5TvX9t2eLkRgCQ6mnPO+R3oJNO1y0 HZD3n7881bjMn04+cQAjPQOQwgIisiwLOSH8AMX3GM8= Original-Received: from mail.jurta.org (m91-129-99-99.cust.tele2.ee [91.129.99.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a88.g.dreamhost.com (Postfix) with ESMTPSA id CAC248138D; Wed, 9 Oct 2019 16:02:33 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a88 In-Reply-To: <87d0f66fi5.fsf@cochranmail.com> (Robert Cochran's message of "Tue, 08 Oct 2019 15:26:10 -0700") X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: 0 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedufedriedvgddukecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufhofhffjgfkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrdelledrleelnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledrleelrdelledprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopehrohgsvghrthdogfhmrggtshestghotghhrhgrnhhmrghilhdrtghomhenucevlhhushhtvghrufhiiigvpeef X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 23.83.209.45 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:240804 Archived-At: > I've added 2 new functions, `tab-bar-rename-tab` and > `tab-bar-rename-tab-by-name`. Both functions take a new name, and a tag > identifier, either a frame tab index or an existing name, > respectively. The new name is then set on the tab, and the > `no-auto-name` parameter is set non-nil, unless the new name is the > empty string, which is taken to mean 'turn automatic naming back on'. Thanks, this is a useful feature. Like the feature of renaming buffers (and using it often to rename such buffers as *Info* and *shell* to match better their content) tab renaming would help to identify tab content better. > A couple of things I'm still wondering about: should this be documented > in the manual? I was going to do so, but couldn't really find a good > spot to mention it. If we do add something to the manual, we should > mention `tab-bar-tab-name-function` as well. Do we want to add this to > the default `C-x 6` binds, possibly as `C-x 6 r`? I already set > `tab-rename` as an alias to `tab-bar-rename-tab`, but I'm curious what > other people are thinking on that. Is there a better name for > `no-auto-name`? I couldn't think of a better one... I was aiming to have > a name who's interpretation as 'nil' is 'don't do anything differently', > so as to make the code slightly easier to read, as well as ensuring > saved tabs don't get automatic naming turned on by mistake. You have a good choice of command names and the key binding. But please give me an additional day to think about a possibility of avoiding `no-auto-name` to not make code unnecessarily complicated.