From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: Michael Heerdegen <michael_heerdegen@web.de>
Cc: Lars Ingebrigtsen <larsi@gnus.org>, emacs-devel@gnu.org
Subject: Re: eww and bookmarks
Date: Mon, 08 Jun 2020 17:58:21 +0100 [thread overview]
Message-ID: <87bllt1olu.fsf@tcd.ie> (raw)
In-Reply-To: <87tuzlwrdv.fsf@web.de> (Michael Heerdegen's message of "Mon, 08 Jun 2020 16:42:36 +0200")
Michael Heerdegen <michael_heerdegen@web.de> writes:
> "Basil L. Contovounesios" <contovob@tcd.ie> writes:
>
>> > +(defcustom bookmark-eww-browse-url-function #'eww-browse-url
>> > + "Doc..."
>> > + :type '(choice
>> > + (function-item eww-browse-url :doc "Use eww")
>> > + (const :tag "Use value of `browse-url-browser-function'" nil)
>> > + function))
>>
>> Isn't it strange having a boookmark-... variable defined in eww.el?
>
> Yes. OTOH I wanted to avoid the risk of confusion with eww bookmarks
> and not call it "eww-bookmark-...". Suggestions?
Is the proposed bookmark.el support not meant to supersede EWW's current
bookmark system?
Anyway, what about eww-browse-bookmark-function?
>> > +(defun eww--bookmark-title (title-string)
>> > + (replace-regexp-in-string
>> > + "\\` +\\| +\\'" ""
>> > + (replace-regexp-in-string "[\n\t\r]" " " title-string)))
>>
>> Is the outer replace-regexp-in-string doing the same as string-trim?
>
> Is it? I didn't touch that code, I only moved it for factoring.
That's what it looks like to me, but you can obviously leave it alone
for now.
>> > +(defun eww-bookmark-make-record ()
>> > + "Create an emacs bookmark record
>> ^^^^^
>> Capitalize
>
> Done.
>
>> > for an eww buffer.
>> > ^^^
>> > Upcase
>
> Is it ok to leave it downcased?
That's what Lars asked for, so yes.
--
Basil
next prev parent reply other threads:[~2020-06-08 16:58 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 11:48 eww and bookmarks Matthias Meulien
2020-05-20 16:29 ` Drew Adams
2020-05-20 16:35 ` Noam Postavsky
2020-05-20 16:40 ` Drew Adams
2020-05-20 20:13 ` Matthias Meulien
2020-05-23 22:56 ` Michael Heerdegen
2020-05-24 8:44 ` Matthias Meulien
2020-05-24 14:14 ` Alfred M. Szmidt
2020-05-24 19:06 ` Karl Fogel
2020-05-25 4:35 ` Michael Heerdegen
2020-05-25 5:26 ` Alfred M. Szmidt
2020-05-26 2:17 ` Michael Heerdegen
2020-06-10 15:39 ` Lars Ingebrigtsen
2020-06-10 20:03 ` Drew Adams
2020-05-25 12:51 ` Stefan Monnier
2020-05-25 13:52 ` Marcin Borkowski
2020-05-25 15:03 ` Alfred M. Szmidt
2020-05-25 15:24 ` Stefan Monnier
2020-05-25 23:40 ` Michael Heerdegen
[not found] ` <e23432dd-212b-4bf0-8e8c-185988c653f0@default>
2020-05-26 1:04 ` Michael Heerdegen
2020-05-27 5:10 ` Drew Adams
2020-05-25 4:28 ` Michael Heerdegen
2020-05-25 14:35 ` T.V Raman
2020-05-20 22:14 ` Michael Heerdegen
2020-06-07 15:09 ` Michael Heerdegen
2020-06-07 15:30 ` Basil L. Contovounesios
2020-06-07 16:13 ` Michael Heerdegen
2020-06-07 16:36 ` Tomas Hlavaty
2020-06-07 18:23 ` Basil L. Contovounesios
2020-06-08 14:49 ` Michael Heerdegen
2020-06-08 16:54 ` Basil L. Contovounesios
2020-06-10 12:01 ` Michael Heerdegen
2020-06-07 16:36 ` Lars Ingebrigtsen
2020-06-07 18:23 ` Basil L. Contovounesios
2020-06-08 14:42 ` Michael Heerdegen
2020-06-08 16:58 ` Basil L. Contovounesios [this message]
2020-06-10 12:06 ` Michael Heerdegen
2020-10-26 18:15 ` Adam Porter
2020-10-26 18:33 ` Drew Adams
2020-10-26 18:43 ` Lars Ingebrigtsen
2020-10-26 19:05 ` Adam Porter
2020-10-26 19:26 ` Karl Fogel
2020-06-07 16:31 ` Clément Pit-Claudel
-- strict thread matches above, loose matches on Subject: below --
2020-05-27 7:18 Boruch Baum
2020-05-27 14:40 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bllt1olu.fsf@tcd.ie \
--to=contovob@tcd.ie \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
--cc=michael_heerdegen@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).