From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] tab-line-alternate-colors Date: Mon, 14 Dec 2020 11:10:06 +0200 Organization: LINKOV.NET Message-ID: <87blewpwf5.fsf@mail.linkov.net> References: <87360autpy.fsf@alphapapa.net> <87mtyiqfzv.fsf@mail.linkov.net> <87tusqt3yr.fsf@alphapapa.net> <87wnxl760u.fsf@mail.linkov.net> <87h7opt3a4.fsf@alphapapa.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12662"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: emacs-devel@gnu.org To: Adam Porter Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Dec 14 10:33:02 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kokE2-0003Bv-4B for ged-emacs-devel@m.gmane-mx.org; Mon, 14 Dec 2020 10:33:02 +0100 Original-Received: from localhost ([::1]:55146 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kokE1-0003JQ-3X for ged-emacs-devel@m.gmane-mx.org; Mon, 14 Dec 2020 04:33:01 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56586) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kokDV-0002sZ-F1 for emacs-devel@gnu.org; Mon, 14 Dec 2020 04:32:29 -0500 Original-Received: from relay3-d.mail.gandi.net ([217.70.183.195]:55789) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kokDT-0002b3-1n for emacs-devel@gnu.org; Mon, 14 Dec 2020 04:32:28 -0500 X-Originating-IP: 91.129.99.98 Original-Received: from mail.gandi.net (m91-129-99-98.cust.tele2.ee [91.129.99.98]) (Authenticated sender: juri@linkov.net) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id B2EBF6000C; Mon, 14 Dec 2020 09:32:21 +0000 (UTC) In-Reply-To: <87h7opt3a4.fsf@alphapapa.net> (Adam Porter's message of "Sun, 13 Dec 2020 22:33:39 -0600") Received-SPF: pass client-ip=217.70.183.195; envelope-from=juri@linkov.net; helo=relay3-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:260792 Archived-At: > Okay, here's my next proposal: The tab-line-tab-face-default function > returns a face, and then a new option, tab-line-tab-face-modifiers, is a > list of functions, each of which is called with that face and returns > it, possibly modified. Thanks, tab-line-tab-face-modifiers is a good idea. It's like hooks used to post-process the result. But the '-hooks' suffix is deprecated, and the new standard is to end such variable names in '-functions'. Then using the name tab-line-tab-face-functions will also avoid ambiguity of the word 'modifiers' that is mostly applied to key modifiers - there is already the option tab-bar-select-tab-modifiers. Then tab-line-tab-face-functions will obsolete the need to have an almost duplicate option tab-line-tab-face-function. But then we have two variants: 1. add tab-line-tab-face-default to tab-line-tab-face-functions by default. 2. remove tab-line-tab-face-default and leave its code in tab-line-format-template as before, with a supposition that it should be sufficient to customize tab-line-tab-face-functions to post-process its output face. What variant would you prefer?