unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Adam Porter <adam@alphapapa.net>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] tab-line-alternate-colors
Date: Mon, 14 Dec 2020 11:10:06 +0200	[thread overview]
Message-ID: <87blewpwf5.fsf@mail.linkov.net> (raw)
In-Reply-To: <87h7opt3a4.fsf@alphapapa.net> (Adam Porter's message of "Sun, 13 Dec 2020 22:33:39 -0600")

> Okay, here's my next proposal: The tab-line-tab-face-default function
> returns a face, and then a new option, tab-line-tab-face-modifiers, is a
> list of functions, each of which is called with that face and returns
> it, possibly modified.

Thanks, tab-line-tab-face-modifiers is a good idea.  It's like hooks
used to post-process the result.  But the '-hooks' suffix is deprecated,
and the new standard is to end such variable names in '-functions'.
Then using the name tab-line-tab-face-functions will also avoid ambiguity
of the word 'modifiers' that is mostly applied to key modifiers -
there is already the option tab-bar-select-tab-modifiers.

Then tab-line-tab-face-functions will obsolete the need to have
an almost duplicate option tab-line-tab-face-function.  But then we have
two variants:

1. add tab-line-tab-face-default to tab-line-tab-face-functions by default.

2. remove tab-line-tab-face-default and leave its code in tab-line-format-template
   as before, with a supposition that it should be sufficient to customize
   tab-line-tab-face-functions to post-process its output face.

What variant would you prefer?



  reply	other threads:[~2020-12-14  9:10 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-13  6:04 [PATCH] tab-line-alternate-colors Adam Porter
2020-12-13  6:17 ` Adam Porter
2020-12-13  8:45 ` Juri Linkov
2020-12-13 10:06   ` Adam Porter
2020-12-13 11:13     ` Adam Porter
2020-12-13 15:21     ` Eli Zaretskii
2020-12-14  2:17       ` Adam Porter
2020-12-14 15:34         ` Eli Zaretskii
2020-12-16  2:58           ` Adam Porter
2020-12-16 15:41             ` Eli Zaretskii
2020-12-13 21:25     ` Juri Linkov
2020-12-14  4:33       ` Adam Porter
2020-12-14  9:10         ` Juri Linkov [this message]
2020-12-14 10:05           ` Adam Porter
2020-12-14 19:37             ` Juri Linkov
2020-12-16  3:24               ` Adam Porter
2020-12-16  3:55                 ` Adam Porter
2020-12-16  9:03                 ` Juri Linkov
2020-12-16 10:26                   ` Adam Porter
2020-12-16 20:46                     ` Juri Linkov
2020-12-18  3:55                       ` Adam Porter
2020-12-23 21:07                         ` Juri Linkov
2020-12-24 11:26                           ` Adam Porter
2020-12-14  9:14         ` Adam Porter
2020-12-14 19:33           ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87blewpwf5.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=adam@alphapapa.net \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).