From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: master a283996: Add command for customizing current newsticker feed Date: Tue, 23 Feb 2021 17:05:48 +0000 Message-ID: <87blcasoib.fsf@tcd.ie> References: <20210223164040.7990.38864@vcs0.savannah.gnu.org> <20210223164041.9DA5D20536@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25089"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Ulf Jasper Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Feb 23 18:06:57 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lEb9C-0006PB-Qi for ged-emacs-devel@m.gmane-mx.org; Tue, 23 Feb 2021 18:06:54 +0100 Original-Received: from localhost ([::1]:44904 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lEb9B-0000iD-T9 for ged-emacs-devel@m.gmane-mx.org; Tue, 23 Feb 2021 12:06:53 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47334) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lEb8F-0000Az-1S for emacs-devel@gnu.org; Tue, 23 Feb 2021 12:05:55 -0500 Original-Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]:34799) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lEb8C-00061n-34 for emacs-devel@gnu.org; Tue, 23 Feb 2021 12:05:54 -0500 Original-Received: by mail-wm1-x332.google.com with SMTP id o10so1945179wmc.1 for ; Tue, 23 Feb 2021 09:05:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=YhpFarC3SC/42/puQ7bSCpomjM4UC5SGIbKnzyoeqwI=; b=K9+X2e/3DhqNqzHVcYoUOPledKmQzraRJG2GbYzALKLjG5T3RMcdFEbnLG19eD3Stz 6VT+T1Hfur5nPJyiAohWUJlpnBdU/LLXosKalZ8rQWDc/nBf5/FgOW5z0CkGwN9CG4Tu FqC7McoQzUm442l/4sQHESKcAyn/zmG28ij/kKW4HGT73Qsi9/OUy1dRGEci7jbmuKmJ FBCl7SeEVWDk+3dvor3LwmE+Dl0xmnACls9xNS0qS+J6gXpSLD/gFlR1xUnCI2/TpK+y pSd8jqqgEQhzFhPrugJ9sQGGoy5PncZy5Id7lIwXnRhX11L+5xPPvYa84rbrf6rrbaBr 2cZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=YhpFarC3SC/42/puQ7bSCpomjM4UC5SGIbKnzyoeqwI=; b=knpCB+D0yp/h8DvCSYb2qxD2qaH7bd4DG8YlRL/hisFxAXtvN1YnlIbNCYt8odBCp7 uRUyspXEtAz9n7BbBDpn8OqJDaHnJVy/zmVRjSgj3niTm/DjdumBYU1bNNiCgfr/XzKs 3VdvUUbh+7Xsm5/ddBxx2OikSJHlnTKbBgroTCLUC2DhoDt1qKp18Zxq3Hoe10/OKnRy nQzuvcK3IjEbs3zbTYE0NQ+8XKlzG/gQKh5sEpyLvgNAyIbHYyvI3xo74nzcUpCbpqz3 7mpQacPQCKlfF21wSVyQGU8NGNJB4SEu+F+nm6OwObmZ3h0ACE5w4Oa7qa4MlFel43On G28g== X-Gm-Message-State: AOAM532id6s6q+ILLj9jojzQtgVL0IdD5vCezsfM8igNgBvbvV+GVEwl BWnN02UpPjQMB480GovSiH+bUw== X-Google-Smtp-Source: ABdhPJxOBRMCT82cipfDFvxPhnplwc/WwBHVFo9eND861sKhbI7GSx21Ni4DP/h9dXXgjL2AfUEDwA== X-Received: by 2002:a1c:3286:: with SMTP id y128mr25915535wmy.104.1614099949824; Tue, 23 Feb 2021 09:05:49 -0800 (PST) Original-Received: from localhost ([2a02:8084:20e2:c380:d15:339e:aa10:60f1]) by smtp.gmail.com with ESMTPSA id k128sm3161682wmf.42.2021.02.23.09.05.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Feb 2021 09:05:49 -0800 (PST) In-Reply-To: <20210223164041.9DA5D20536@vcs0.savannah.gnu.org> (Ulf Jasper's message of "Tue, 23 Feb 2021 11:40:41 -0500 (EST)") Received-SPF: none client-ip=2a00:1450:4864:20::332; envelope-from=contovob@tcd.ie; helo=mail-wm1-x332.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:265540 Archived-At: ulf.jasper@web.de (Ulf Jasper) writes: > branch: master > commit a283996fc728e249816d3bd43a6da1f3c0eab837 > Author: Ulf Jasper > Commit: Ulf Jasper > > Add command for customizing current newsticker feed [...] > +(defun newsticker-customize-feed (feed-name) > + "Open customization buffer for `newsticker-url-list' and jump to FEED-NAME." > + (interactive > + (list (completing-read "Name of feed or group to edit: " > + (append (mapcar #'car newsticker-url-list) FWIW, completing-read also accepts alists with string/symbol keys directly. > + nil t feed-name)))) This call to (append (..) nil t feed-name) will signal an error. > + (customize-variable 'newsticker-url-list) > + (delete-other-windows) Doesn't this interfere with the user's display-buffer-alist customisations? customize-variable uses pop-to-buffer, so in theory no further window adjustment should be necessary. > + (when (re-search-forward (concat "Label: " feed-name) nil t) Should this be 'search-forward' instead? Thanks, -- Basil