unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: Ulf Jasper <ulf.jasper@web.de>
Cc: emacs-devel@gnu.org
Subject: Re: master a283996: Add command for customizing current newsticker feed
Date: Tue, 23 Feb 2021 17:05:48 +0000	[thread overview]
Message-ID: <87blcasoib.fsf@tcd.ie> (raw)
In-Reply-To: <20210223164041.9DA5D20536@vcs0.savannah.gnu.org> (Ulf Jasper's message of "Tue, 23 Feb 2021 11:40:41 -0500 (EST)")

ulf.jasper@web.de (Ulf Jasper) writes:

> branch: master
> commit a283996fc728e249816d3bd43a6da1f3c0eab837
> Author: Ulf Jasper <ulf.jasper@web.de>
> Commit: Ulf Jasper <ulf.jasper@web.de>
>
>     Add command for customizing current newsticker feed

[...]

> +(defun newsticker-customize-feed (feed-name)
> +  "Open customization buffer for `newsticker-url-list' and jump to FEED-NAME."
> +  (interactive
> +   (list (completing-read "Name of feed or group to edit: "
> +                          (append (mapcar #'car newsticker-url-list)

FWIW, completing-read also accepts alists with string/symbol keys
directly.

> +                                  nil t feed-name))))

This call to (append (..) nil t feed-name) will signal an error.

> +  (customize-variable 'newsticker-url-list)
> +  (delete-other-windows)

Doesn't this interfere with the user's display-buffer-alist
customisations?  customize-variable uses pop-to-buffer, so in
theory no further window adjustment should be necessary.

> +  (when (re-search-forward (concat "Label: " feed-name) nil t)

Should this be 'search-forward' instead?

Thanks,

-- 
Basil



       reply	other threads:[~2021-02-23 17:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210223164040.7990.38864@vcs0.savannah.gnu.org>
     [not found] ` <20210223164041.9DA5D20536@vcs0.savannah.gnu.org>
2021-02-23 17:05   ` Basil L. Contovounesios [this message]
2021-02-23 18:38     ` master a283996: Add command for customizing current newsticker feed Ulf Jasper
2021-02-23 17:35 Eli Zaretskii
2021-02-23 18:38 ` Ulf Jasper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87blcasoib.fsf@tcd.ie \
    --to=contovob@tcd.ie \
    --cc=emacs-devel@gnu.org \
    --cc=ulf.jasper@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).