From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Omar Polo Newsgroups: gmane.emacs.devel Subject: Re: Recent pcase changes Date: Thu, 04 Mar 2021 12:40:19 +0100 Message-ID: <87blbzkuzg.fsf@omarpolo.com> References: <7c26cf68-90d6-a36c-59d9-0d737d1ff143@inventati.org> <586BC11A-0E1F-48ED-B69D-0ED2E809A0DE@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1420"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.4.14; emacs 28.0.50 Cc: Manuel Uberti , emacs-devel@gnu.org To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Mar 04 12:42:09 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lHmMq-0000Ga-Ju for ged-emacs-devel@m.gmane-mx.org; Thu, 04 Mar 2021 12:42:08 +0100 Original-Received: from localhost ([::1]:38062 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHmMp-0002ge-LJ for ged-emacs-devel@m.gmane-mx.org; Thu, 04 Mar 2021 06:42:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40844) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHmLM-00013v-Bz for emacs-devel@gnu.org; Thu, 04 Mar 2021 06:40:36 -0500 Original-Received: from mail.omarpolo.com ([144.91.116.244]:51822) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHmLJ-0006Bi-KV for emacs-devel@gnu.org; Thu, 04 Mar 2021 06:40:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=omarpolo.com; s=20200327; t=1614858020; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=moJaHHM+OULJAZVzAJ23zQbRj9fH+1l3hWjMFc+3BAE=; b=glWzdOof68i9dgNltmgcWLIxEPnMi7QgMomVTGw0T0+/1Z4QjZVjLt8LAu0aYX97kggiMW aLi93L7pfz+7EY+P+79wq9AJjR0vjkaIVVeu8gpHouTgDtsRt5RCbijBGY5MyiChIO54x0 Hri7wOSdab0pFskVRpUVfdWLkW9g9Ow= Original-Received: from localhost (host-79-20-13-205.retail.telecomitalia.it [79.20.13.205]) by mail.omarpolo.com (OpenSMTPD) with ESMTPSA id 1d3392b5 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Thu, 4 Mar 2021 12:40:20 +0100 (CET) Original-Received: from venera (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 60781586; Thu, 4 Mar 2021 12:40:19 +0100 (CET) In-reply-to: <586BC11A-0E1F-48ED-B69D-0ED2E809A0DE@acm.org> Received-SPF: pass client-ip=144.91.116.244; envelope-from=op@omarpolo.com; helo=mail.omarpolo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:265945 Archived-At: Mattias Engdeg=C3=A5rd writes: > 4 mars 2021 kl. 11.06 skrev Manuel Uberti : > >> By looking at clojure-mode code I see it sets `lisp-indent-function' to >> `clojure-indent-function', which makes use of `pcase'. More specifically= , this >> is what it does at line 1497 of clojure-mode.el: >>=20 >> (pcase method >> ((or (pred integerp) `(,method)) > > Now all variables in an `or`-pattern are always bound, to nil if nothing = else. Try: > > ((or (pred integerp) `(m)) > (let ((method (if (integerp method) method m))) > ... Yes, that fixes the issue for me, thanks!