unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Philip Kaludercic <philipk@posteo.net>
To: Ivan Sokolov <ivan-p-sokolov@ya.ru>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] Add buffer name option for project-compile
Date: Mon, 12 Apr 2021 10:13:44 +0200	[thread overview]
Message-ID: <87blaj6htz.fsf@posteo.net> (raw)
In-Reply-To: <29479451618183143@myt6-2b82e4d1fc0a.qloud-c.yandex.net> (Ivan Sokolov's message of "Mon, 12 Apr 2021 02:19:03 +0300")

Ivan Sokolov <ivan-p-sokolov@ya.ru> writes:

> +(defun project--compilation-buffer-name (mode)
> +  (concat "*"
> +          (file-name-nondirectory
> +           (directory-file-name default-directory))

Should this be the default directory or the project root?

> +          "-"
> +          (downcase mode)
> +          "*"))

-- 
	Philip K.



  reply	other threads:[~2021-04-12  8:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-11 23:19 [PATCH] Add buffer name option for project-compile Ivan Sokolov
2021-04-12  8:13 ` Philip Kaludercic [this message]
2021-04-12 10:34   ` Ivan Sokolov
2021-04-23  0:17 ` Dmitry Gutov
2021-04-23  3:09   ` Ivan Sokolov
2021-04-23  6:14     ` [PATCH] " Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87blaj6htz.fsf@posteo.net \
    --to=philipk@posteo.net \
    --cc=emacs-devel@gnu.org \
    --cc=ivan-p-sokolov@ya.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).