From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Augusto Stoffel Newsgroups: gmane.emacs.devel Subject: Re: Simple isearch concerns Date: Mon, 26 Apr 2021 07:39:29 +0200 Message-ID: <87bla11u5q.fsf@gmail.com> References: <20210403001539.x4rb55dvh46rmhb3.ref@Ergus> <20210403001539.x4rb55dvh46rmhb3@Ergus> <2599ffef-4f70-025c-5f9c-61b9ac94faf8@inventati.org> <87eefrbo9k.fsf@posteo.net> <7473b27b2b479f5686af@heytings.org> <87tuon9vf1.fsf@posteo.net> <20210403174508.xwr5uc36dzityitn@Ergus> <87wnsurdr7.fsf@gmail.com> <87fszij6to.fsf@mail.linkov.net> <87v98asulc.fsf@gmail.com> <87pmyimiwd.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36725"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) Cc: Philip Kaludercic , Ergus , Manuel Uberti , Gregory Heytings , emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Apr 26 13:27:27 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lazOf-0009Gd-TL for ged-emacs-devel@m.gmane-mx.org; Mon, 26 Apr 2021 13:27:25 +0200 Original-Received: from localhost ([::1]:36214 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lazOf-0000sf-0c for ged-emacs-devel@m.gmane-mx.org; Mon, 26 Apr 2021 07:27:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54164) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1latyD-0007QH-7e for emacs-devel@gnu.org; Mon, 26 Apr 2021 01:39:45 -0400 Original-Received: from mail-ej1-x636.google.com ([2a00:1450:4864:20::636]:38659) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1laty1-0002n2-Ft for emacs-devel@gnu.org; Mon, 26 Apr 2021 01:39:43 -0400 Original-Received: by mail-ej1-x636.google.com with SMTP id r12so82558652ejr.5 for ; Sun, 25 Apr 2021 22:39:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=UK0ok1tdWgD2xMWQGe9n1rMzTMv9TZqQAFsLYozI0MQ=; b=MCZ76PSCmuBsGNUlAmu7hldZWVZgUgfX4vs62d3Sh51E8TXXT6vkExtoG1pz+1WxxQ kn6Gb+R4xKK9+he3PVK2hZycLItTAOHHOvItPq95V5EHYLJqeWX3MgY4H7WGPMvyAtkl JfTl/jhkyE7ewlKRr9KkfB9Iy3h72Lf/qaIcxtG/bf/zpHdcFWvq5KhFs5aGl7bVUd18 tocSJAkWEOgo6dHAenY7JF7+5N1pkdQTWV5p1IIB63kL3QnFE7qlyFwZ4kk2fzQ85zKl iw/40pEhIgkhSIcblu49YvmDPIOPh/qkG9rKa0r2Lx3AMIiSJkYPO0WNROHSoLKdP2w5 +tfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=UK0ok1tdWgD2xMWQGe9n1rMzTMv9TZqQAFsLYozI0MQ=; b=ArkJ2uh7uIc+A1HZsyYQ7ery0KcsnYXId8nEhrLnG4ZDnl/ElQsFg5PTNzq0UChrbt JYky3fd7iW0xkkLYfT1dNuuCt8srWpwzP/JAinWd7BrHAPIRu1vTtzfa1wWcmklLyXKa xQ+8XYT6cxvstmrs6RZ0bEsxHRQts9oDK+b58TpHNP1VfBMv1Ud3wrKknEsBvHMRKnU6 2hu7tQDm75zdMdUDbD4y+V0GiQRum1558AABV7orvaoAouMFSTzFhv1R0TRnYUB+35Rx UjcfIN7CsCn8o6j6ipGBPMajvzYhXEgtioSyPY2E1ab7Dx80Tvfdu2xA5ZdjwjVsGHxa Tx1g== X-Gm-Message-State: AOAM5305tCe8SdgdBYcndYQ03iWpIg/j10R2abrrRi1nRKeprctZmYjs ryE+502XOSY8m5+o/UrDzw1VDyrCVlBesQ== X-Google-Smtp-Source: ABdhPJyV7rDjuujCmToJT7irCkcKjEY6wQRd2fGMS6HcRJKClgDrse2ETJqxZtLrDoU+sarICebA9A== X-Received: by 2002:a17:906:7d82:: with SMTP id v2mr17044649ejo.524.1619415570844; Sun, 25 Apr 2021 22:39:30 -0700 (PDT) Original-Received: from ars3 ([2a02:908:2211:8540::68a]) by smtp.gmail.com with ESMTPSA id i19sm8981152ejd.114.2021.04.25.22.39.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Apr 2021 22:39:30 -0700 (PDT) In-Reply-To: <87pmyimiwd.fsf@mail.linkov.net> (Juri Linkov's message of "Sun, 25 Apr 2021 20:24:50 +0300") Received-SPF: pass client-ip=2a00:1450:4864:20::636; envelope-from=arstoffel@gmail.com; helo=mail-ej1-x636.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Mon, 26 Apr 2021 07:25:27 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:268451 Archived-At: On Sun, 25 Apr 2021 at 20:24, Juri Linkov wrote: > If its implementation becomes more hackish, then it would make > more sense as an external package. Otherwise, if we can find > an elegant way to naturally integrate it with isearch.el, > then this feature could make it into isearch.el. This can be decided at any time, since an implementation exists. It's not really that hacky. But I don't know if it breaks some obscure functionality or extension of Isearch. However, contrary to my original statement, it now works with all Isearch extensions I know/care about (Embark, Consult, Loccur, Anzu's query-replace, pdf-tools), possibly after applying an advice. > But trying to make buffer-local overriding-terminal-local-map with: > > (setq-local overriding-terminal-local-map isearch-mode-map) > > fails with an error: > > Debugger entered--Lisp error: (error "Symbol overriding-terminal-local-map may not be buffer-local") > make-local-variable(overriding-terminal-local-map) > (set (make-local-variable 'overriding-terminal-local-map) isearch-mode-map) > isearch-mode(t nil nil nil) > isearch-forward(nil 1) Is this overriding map there just so that `isearch-mode-map' takes precedence over other minor mode maps? If so, couldn't this be achieved by manipulating minor-mode-map-alist to put Isearch's map at the top? Maybe that can be done buffer-locally.