From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Karl Fogel Newsgroups: gmane.emacs.devel Subject: Re: [External] : Re: [PATCH] When deleting in bookmark menu, prompt for confirmation. Date: Wed, 26 May 2021 14:33:44 -0500 Message-ID: <87bl8xguhz.fsf@red-bean.com> References: <87a6pcqy7s.fsf@red-bean.com> <835z006jpl.fsf@gnu.org> <87im3z3f8f.fsf@red-bean.com> <83zgxb67g2.fsf@gnu.org> <87mtt9sqh4.fsf@red-bean.com> <87czu58uso.fsf@gnus.org> <878s4tq8e6.fsf@red-bean.com> <874kfguail.fsf@red-bean.com> <875yzwtkuj.fsf@gmail.com> <87lf8prm2f.fsf@gmail.com> <83eeeg8ez9.fsf@gnu.org> <87h7jboirj.fsf@red-bean.com> <83cztz7nvd.fsf@gnu.org> <87wnrn4bld.fsf@red-bean.com> <83cztfc8vh.fsf@gnu.org> <87fsyatvcj.fsf@red-bean.com> <837djlbt8v.fsf@gnu.org> Reply-To: Karl Fogel Mime-Version: 1.0 Content-Type: text/plain; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25793"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: larsi@gnus.org, orontee@gmail.com, monnier@iro.umontreal.ca, drew.adams@oracle.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed May 26 21:38:50 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1llzMf-0006Wy-4O for ged-emacs-devel@m.gmane-mx.org; Wed, 26 May 2021 21:38:49 +0200 Original-Received: from localhost ([::1]:35210 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1llzMe-0004Tz-6U for ged-emacs-devel@m.gmane-mx.org; Wed, 26 May 2021 15:38:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46104) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llzI3-0000Ka-TX for emacs-devel@gnu.org; Wed, 26 May 2021 15:34:03 -0400 Original-Received: from sanpietro.red-bean.com ([45.79.25.59]:57418) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llzI1-00023f-Vf; Wed, 26 May 2021 15:34:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=red-bean.com; s=202005newsp; h=Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:Reply-To:References:Subject:Cc:To:From:Sender: Content-Transfer-Encoding:Content-ID:Content-Description; bh=MCvoyIAAU0ts6g24dHxYiJnAIOUWkFewZyecdRFB818=; t=1622057639; x=1623267239; b=jS8LG5HHxbvN+pkhrYX3Yt8zVmk81lOhCnen87psBMMK2fSDWH7SmhIF12qSU2MpqnfMi9E3Un zPgodPj+jpN1tr4EHqk+C463wNCCiIU6/YqNR+utQllByVUogMKkCPhC6xU5Qehh6fdY+Hrm1WoB5 nlaE/IovLMBBvudNwj2zrnFM4XcWSHje0VPsluC/rEkTxeARO7EfwN7dcqWAofrW6xAL8GCYfUq20 RXmHK2AUAU7oF7tCWOHF1VnF5FTDjWv6MWPXdMBM+Pp778sQkveACx+InB4HLkG5nTulhlzZR2uKm Ntzo1/wK1IN1hk+ECf3fzCE64cFX2aL2gN2Zg==; Original-Received: from [12.106.183.66] (port=3543 helo=kwork) by sanpietro.red-bean.com with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1llzHk-0004aD-QX; Wed, 26 May 2021 19:33:44 +0000 In-Reply-To: <837djlbt8v.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 26 May 2021 14:59:44 +0300") Received-SPF: pass client-ip=45.79.25.59; envelope-from=kfogel@red-bean.com; helo=sanpietro.red-bean.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269925 Archived-At: On 26 May 2021, Eli Zaretskii wrote: >> From: Karl Fogel >> Cc: orontee@gmail.com, drew.adams@oracle.com, larsi@gnus.org, >> monnier@iro.umontreal.ca, emacs-devel@gnu.org >> Date: Tue, 25 May 2021 15:24:44 -0500 >> >> >Given what you wrote, and what bookmark-load does with the >> >prefix >> >argument, I think it is better to say that explicitly in >> >bookmark-bmenu-load's doc string, since you only need a single >> >quite >> >simple sentence to say that, whereas the doc strong of >> >bookmark-load >> >is quite long. >> >> Well, now that I've done it, I think your way is an improvement >> -- >> although it turned out to be slightly more doc change than I >> expected. Revised patch attached for review. > >LGTM, thanks. Thanks for the review, Eli. Committed (c4e8d1dbe2e) on master. The reason it's 'master' instead of 'emacs-27' is that the patch doesn't apply cleanly on 'emacs-27', and the effort needed to adjust it didn't seem worth it to me. (If these documentation updates were urgently needed by users, I'd make a different decision, but I don't think that's the case.) Best regards, -Karl