From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: master 28bf387: Tweak Fdirectory_append for efficiency Date: Sat, 24 Jul 2021 19:05:20 +0200 Message-ID: <87bl6r1w33.fsf@gnus.org> References: <8335s3zng8.fsf@gnu.org> <87sg031xrc.fsf@gnus.org> <831r7nzn27.fsf@gnu.org> <87k0lf1wt4.fsf@gnus.org> <83sg03y7g7.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19001"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jul 24 19:06:12 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m7L6I-0004jn-QW for ged-emacs-devel@m.gmane-mx.org; Sat, 24 Jul 2021 19:06:10 +0200 Original-Received: from localhost ([::1]:52604 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m7L6H-00083W-TI for ged-emacs-devel@m.gmane-mx.org; Sat, 24 Jul 2021 13:06:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33196) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m7L5c-0006xB-EX for emacs-devel@gnu.org; Sat, 24 Jul 2021 13:05:28 -0400 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:53594) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m7L5a-0006r0-35; Sat, 24 Jul 2021 13:05:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=k40WYmLWKMzEZVR677zxzRRsDeLI1BmbftTz51JO+k0=; b=XrrGtUui2w+DWHeVg4tU/UeD7c 1anGMwfwYC4HCqxjBqGiB2r2AZ4Jn7tlW+cmPOrT+mYRSGvc1W54lee8eGWwiQal/P7b4qdh4sIO2 rYsMJv/xwdyOuAPEU1vJw5BhXX4a8J53Dtw04v3UOoA5hmNR48ChXfg48Si0A72/okIA=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m7L5V-0007Wm-An; Sat, 24 Jul 2021 19:05:23 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAG1BMVEXq3NL9/fvisZTn w6e2U0qwinTgoWxGLC7///+QgKddAAAAAWJLR0QIht6VegAAAAd0SU1FB+UHGBAzBELwgagAAAGs SURBVDjL3dTNjpswEADgcbJpr56g7hnsjXvFWOJcsU56TQlsrlnDzgOsdt+/Y0r+KH2BIgHWfMxY HluAwNlLAgqUUkiJAjC+5fBEZBAcjMC5QwgHhn+U+n8ghTtLLuC1y+fSoAlBKZfPgPe+VWoqyQB+ 2yquBnCFb9D7P2IR5Hp/mewB3gbYVbngvTmcK0oPLxz+8L5aZLjSdTamJG8XcJD8rFs7psgGXoZJ js8FiO+fKpNjLQZqm83WVzng8bP5IcdaHgLxAlvv6xSP75utGOEJahUcwNI5gV/fTajPs0PQahgV AtcftS7tuSVhHBe5WDa+RXEF18XBKkV89P7XpYnBORNTVtz7pKnrKyhXxhS52qPcqPQGtDInho1u davsDSjjDH+4dA/7xQFvIVDRZyxwsNc9BuqccURk4/G/3VoiXWBCVI1tvQOL0vSvk8NApJzmL/vn KRjqOAUX3RQ0lcUkOIKTHdkZCIX9otMZqJyWXSHuommEnSvFWp2GwLliHuGp46gh8VcpsyPCR/M6 hZJ6UhnSSU6A27RTAZNT/LtwIN78u+E7psys4zcuuoaYrmIHhAAAACV0RVh0ZGF0ZTpjcmVhdGUA MjAyMS0wNy0yNFQxNjo1MTowNCswMDowMAa3iP0AAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjEtMDct MjRUMTY6NTE6MDQrMDA6MDB36jBBAAAAAElFTkSuQmCC X-Now-Playing: Suicide's _Alan Vega * Martin Rev_: "Fast Money Music" In-Reply-To: <83sg03y7g7.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 24 Jul 2021 19:58:48 +0300") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:271561 Archived-At: Eli Zaretskii writes: >> So that when constructing the final string all the elements have the >> same(ish) multibytedness. > > Why not just require that up front? It makes no sense to append > strings of different multibytedness to make a single file name from > them. The only cases that make sense to me are: > > . all the strings are multibyte > . some of the strings are multibyte, and some unibyte and pure-ASCII > . all the strings are unibyte > > The last case can happen when we call this function very early during > the startup process, before we set up the file-encoding stuff, and > thus all the file names are unibyte strings. I don't understand your point here, I'm afraid. Whenever there's (multibyte-string-p "/tmp") =3D> nil (multibyte-string-p "b=C3=A1r") =3D> t Why shouldn't I be able to run (directory-append "/tmp" "b=C3=A1r") =3D> "/tmp/b=C3=A1r" without caring about multibytedness? This is just a string manipulation function (geared towards file names). --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no