unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: tumashu <tumashu@163.com>
Cc: "emacs-devel@gnu.org" <emacs-devel@gnu.org>
Subject: Re: [patch] two patchs about tab-bar.el
Date: Fri, 10 Sep 2021 19:17:33 +0300	[thread overview]
Message-ID: <87bl50fozu.fsf@mail.linkov.net> (raw)
In-Reply-To: <340a0f4.6ac9.17bcfeccbb7.Coremail.tumashu@163.com> (tumashu@163.com's message of "Fri, 10 Sep 2021 21:36:47 +0800 (CST)")

> I have two tabs:
>
> 1. *scratch*  2. *scratch*, *Messages*
>
> and current-tab is 2
>
> if I switch-to-buffer *scratch*, it will switch to tab 1, instead of
> jump to window '*scratch*' in current tab.
>
> for current-tab is not at the beginning of tabs.

Please send your customized settings related to tab-bar.
I see that you set 'tab-bar-tab-name-function' to 'tab-bar-tab-name-all'.
What other tab-bar customization do you have that causes buffer-switching
also select another tab?  Is it something in display-buffer-alist
that is customized to use display-buffer-in-tab?

>>>  If ALIST contains a `reusable-frames' entry, its value determines
>>>  which frames to search for a reusable tab:
>>> -  nil -- the selected frame (actually the last non-minibuffer frame)
>>> +  nil -- do not reuse any frames.
>>>    A frame   -- just that frame
>>>    `visible' -- all visible frames
>>>    0   -- all frames on the current terminal
>>>    t   -- all frames.
>>> +  others -- selected frame.
>>
>> I wonder where did you get the value 'others' that means the selected frame?
>
> (defun tab-bar--reusable-frames (all-frames)
>   (cond
>    ((eq all-frames t) (frame-list))
>    ((eq all-frames 'visible) (visible-frame-list))
>    ((framep all-frames) (list all-frames))
>    (t (list (selected-frame)))))

Thanks, I thought that `others' is a symbol because is looks like `visible'.
If you meant that all other values affect the selected frame, then better
to use such wording: "other non-nil values".



  reply	other threads:[~2021-09-10 16:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-10  4:39 [patch] two patchs about tab-bar.el tumashu
2021-09-10  6:33 ` Juri Linkov
2021-09-10 13:18   ` tumashu
2021-09-10 13:24   ` tumashu
2021-09-10 13:36   ` tumashu
2021-09-10 16:17     ` Juri Linkov [this message]
2021-09-10 18:33   ` tumashu
2021-09-12  7:03     ` Juri Linkov
2021-09-12  9:34       ` tumashu
2021-09-12 16:10         ` Juri Linkov
2021-09-10 23:48 ` Feng Shu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bl50fozu.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=emacs-devel@gnu.org \
    --cc=tumashu@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).