From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: 2a73673 Change how thread-first/thread-last indent the first argument Date: Wed, 06 Oct 2021 11:08:49 +0200 Message-ID: <87bl42frku.fsf@gnus.org> References: <87ee90vtye.fsf@alphapapa.net> <87czoj7wlk.fsf@gnus.org> <875yubx3rj.fsf@alphapapa.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33349"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Adam Porter Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Oct 06 11:10:32 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mY2wa-0008VC-0r for ged-emacs-devel@m.gmane-mx.org; Wed, 06 Oct 2021 11:10:32 +0200 Original-Received: from localhost ([::1]:35188 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mY2wZ-0004RC-3Q for ged-emacs-devel@m.gmane-mx.org; Wed, 06 Oct 2021 05:10:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38140) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mY2v5-00036Z-3x for emacs-devel@gnu.org; Wed, 06 Oct 2021 05:08:59 -0400 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:41022) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mY2v3-00065e-JH for emacs-devel@gnu.org; Wed, 06 Oct 2021 05:08:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=NdK/NhEetXdGiZ4aXCgGwxRr1lUAhO1WmkrjEWh3gTE=; b=R7keO+OlW/H3VbDeXpyDiHh8ya 0NyoionX97J2b762KyafI0EqTmCh8AT341EEYI+u/Qu3B5zhx++GdBrJg09/TOwWdo8e00Zv8r9Bc /m5s7UZObKHWsYqcEUXJOuf4y3Bmgx1OeFnF0JbFUqa85VWvlXWkSE4JhvbBV/ncSTHA=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mY2ux-0000Im-HZ; Wed, 06 Oct 2021 11:08:54 +0200 X-Now-Playing: DJ Screw's _All Work, No Play_: "DJ Screw Fat Pat Herschelwood Hardheadz Pimps Playas Hustlers feat Fat Pat Herschelwood Ha" In-Reply-To: <875yubx3rj.fsf@alphapapa.net> (Adam Porter's message of "Tue, 05 Oct 2021 03:41:20 -0500") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:276416 Archived-At: Adam Porter writes: > Another issue is that, since older Emacs versions persist in the wild > for years, this will result in code changing indentation between Emacs > versions: if someone submits a patch based on Emacs <28, it will have > one indentation, and if the maintainer uses Emacs 28, it will have > another indentation. That's true of any indentation change, but we do make those, anyway. In Emacs 28 we changed how '( foo bar) is indented, and in Emacs 29 we've changed how cl-flet is indented. (The first change probably didn't entail any churn because nobody wrote something like that before, but the cl-flet one does introduce churn.) So the question is whether the old indentation was a bug or not, and it looks like a bug to me. That is, the only documentation of the form we have indents the way it does now (after the change). On the other hand, the documentation could be incorrect. I don't really have much of an opinion here -- but the old indentation looks like a bug to me. If the thread-first/last community disagrees with this, I'm open to reverting the patch. Does anybody else have an opinion here? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no