Re: lazy-count-update-hook run with inconsistent point

[Augusto Stoffel <arstoffel@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 956 bytes --]

Hi Jai,

On Fri, 25 Mar 2022 at 11:04, Jai Flack <jflack@disroot.org> wrote:

> What do you think about lazy-count-update-hook being run with
> inconsistent point? It's called from three points in isearch.el and from
> best I can tell, for two of those (in isearch-lazy-highlight-new-loop)
> it is always called with point at the current match (start or end
> depending on forward or reverse search); however the last call (in
> isearch-lazy-highlight-buffer-update) is inside the save-excursion and
> so the point is wherever the last overlay has been created.
>
> I can't see any reason for this inconsistency in the UI updating code
> (starting line 4338 on 392d66f6f5) so should this be moved outside the
> save-excursion or rather documented as unreliable?

It should be reliable.

> Note: my package can use isearch-match-data so this is just a minor
> implementation detail.

Anyway, that was an oversight.  Does the patch below solve the problem?


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Always-run-isearch-lazy-count-update-hook-with-point.patch --]
[-- Type: text/x-patch, Size: 1297 bytes --]

From 6b656aa52dd539c519daab21ccef337366a9eb91 Mon Sep 17 00:00:00 2001
From: Augusto Stoffel <arstoffel@gmail.com>
Date: Fri, 25 Mar 2022 08:46:57 +0100
Subject: [PATCH] Always run 'isearch-lazy-count-update-hook' with point at
 match

* lisp/isearch.el (isearch-lazy-highlight-buffer-update):  Run
'isearch-lazy-count-update-hook' outside of save-excursion, so point
is at the current match.
---
 lisp/isearch.el | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/lisp/isearch.el b/lisp/isearch.el
index 9b311cb49e..6cee39c70a 100644
--- a/lisp/isearch.el
+++ b/lisp/isearch.el
@@ -4342,11 +4342,12 @@ isearch-lazy-highlight-buffer-update
 		  (setq isearch-lazy-count-current
 			(gethash opoint isearch-lazy-count-hash 0))
                   (when (and isearch-mode (null isearch-message-function))
-                    (isearch-message))
-		  (run-hooks 'lazy-count-update-hook))
+                    (isearch-message)))
 	      (setq isearch-lazy-highlight-timer
 		    (run-at-time lazy-highlight-interval nil
-				 'isearch-lazy-highlight-buffer-update)))))))))
+				 'isearch-lazy-highlight-buffer-update)))))
+        (when nomore
+          (run-hooks 'lazy-count-update-hook))))))
 
 \f
 ;; Reading from minibuffer with lazy highlight and match count
-- 
2.35.1