From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: master 5141234acf: Refactor the webp cache code to allow usage by gif_load, too Date: Mon, 11 Apr 2022 20:15:12 +0800 Message-ID: <87bkx73jfz.fsf@yahoo.com> References: <164967696186.12152.11548736665906939483@vcs2.savannah.gnu.org> <20220411113602.7A114C0581E@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37031"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) Cc: Lars Ingebrigtsen To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Apr 11 14:16:41 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ndsyH-0009QX-Tt for ged-emacs-devel@m.gmane-mx.org; Mon, 11 Apr 2022 14:16:41 +0200 Original-Received: from localhost ([::1]:59744 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ndsyG-0000Ic-Oy for ged-emacs-devel@m.gmane-mx.org; Mon, 11 Apr 2022 08:16:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52672) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ndsxC-0007dZ-IU for emacs-devel@gnu.org; Mon, 11 Apr 2022 08:15:34 -0400 Original-Received: from sonic317-34.consmr.mail.ne1.yahoo.com ([66.163.184.45]:45011) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ndsx9-0002Oq-2B for emacs-devel@gnu.org; Mon, 11 Apr 2022 08:15:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1649679322; bh=ugSzDF/efTT9bYCvL1P9P8Pl7jPhasiWM99i1i5rosg=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=ZS4fPP0f6wKgPr7VVZnKRTuosCt4ymfM/gyEoc2wG27hlybWouXcqH2KyFtNCl+YdVirjO+RAIcg65qk5yLwub0E3MnzCYxN6MGQM6umakxRCtVrnV4zbqlshI4zwrmZnk8K12IfQOpN52OrOjN4SOr0RIFsGKG1LRngCrnUXjDNbAZJ3YBge1hQ5hl4kv/Mt0M1ennjSC+tA12ZtpXguSUy/A2qT+Noc2hBzjMiZbTjTQooxAWqtfbmZ6XVP0YEiEtKzEJfAJrVM4MKER4Ny5fpv+hOB2JGd/B3iXQ9SBXtBMk/PkmhOMJ5vGvOwId7r/e4kZoSsOAdadUUBjpA0Q== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1649679322; bh=tIYtVHSutq0QWu1enJhYIowtXxzgA+DJEn95hCRo/yR=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=nbiFMmxFQAO5xsHm8eBV3on48AKOmMtFujpyP8BfPZWYGf4bdELQ59jtPP8VYpTvijESF2OGQCtO3kD2RHUVe1JSmesSmjj+dX6qSpGMANayH5J9lKq8ynNk81lsXXfZuv6DfrykDBW6LJ3z78d1yLFVdf4fzn4GGtbxE7EXW8dtYvUDD2XeO9OCQyW7olE5IlyQCvo+DGWA9F8NmNLmhuZG3vaj77DlaahRN2JTKIV+ZWgf+35jatftfHSNmKQxSD3puIk5AHD99SXcYG6tT/KOiy2OFPVEU52tJ0iG7rumAlyRk6s2ijVTG7naEILLqwPV26fXHjrYgKSNWL+GyA== X-YMail-OSG: fVFC3okVM1myqplb_ffaJwuBq7enGLzzzxg1L.9k8xsMocXyh26DUHh5VsagmGN yBCirsoNF4tDsJDCR7iKQ9FiLr5bIZXVbLZ0uzozEqSgB.W_6NLDwOat4SUpM81tLWISpO9s_cWV Zkzliw3zdaegVe52LhZla5v23GQmjxc7XXQSFdIkEhgtNWPwXPCCbGLlbIpm70Mtn3.BLuK6etMK 5NmGp9GIX1CvD4tqq8QiBUqstejHayxGrsdZyDAcPQrRDYsx7a2G3_BNR0X1MJc49YyWxBahYfOr DZxfGdieEev7f1hCwcbVWosWcFbppG_QMyKTVKHSEgkERC6sfUQAVPJgWhSy.M_Gxslvk3U4CC4Z 3HXjvz_plqReFSRnPskVuyRqUBYlxk6ym7B7db.dGaVvyURD0hD50if5w1Hm0tZfP6c7iH25dmE2 p06gX._MZMKyGkKJ2TK7jLq5EZVMBNMXoIr6ZkhqVVCNP6vVtSTiiGqsjd9U_F6kZaOaTAimbkUY IdRM2K4uzrua65ii2ch_mlEnNscC0Ly6JAg8sBZCmtsn5pbebWGmPADgz7zNx7XMVAexUnnIAmUA iSc4Jbyg4MX4kwscsEcme8BRHOqqhRdTdVoOjfyCCwS0GSAmAggSotvWByqM.FYU2HjHbu35HgT. Az1x8lN6CdBaSNqNTwZp5uJx0Nr9VTNLlK960tVIA0S_kXcYjWAziVFkklHWUQzpbKLzjXZKy1Vr DpAxCeowvqR5MdNE4bNhxib9d_eLs.VfVif1IN0inrquixeZr9EpbooD3LNjWn.XywIiQtWvNSgf SCOZO8Um6P7fhUvLjFj.sLMkxR2CGMwwc7M2i6mJbV X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic317.consmr.mail.ne1.yahoo.com with HTTP; Mon, 11 Apr 2022 12:15:22 +0000 Original-Received: by hermes--canary-production-sg3-65d7bd97b5-rvrjv (VZM Hermes SMTP Server) with ESMTPA ID effec3b15847d7f4dd645623d2cb6684; Mon, 11 Apr 2022 12:15:16 +0000 (UTC) In-Reply-To: <20220411113602.7A114C0581E@vcs2.savannah.gnu.org> (Lars Ingebrigtsen's message of "Mon, 11 Apr 2022 07:36:02 -0400 (EDT)") X-Mailer: WebService/1.1.20048 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.184.45; envelope-from=luangruo@yahoo.com; helo=sonic317-34.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:288180 Archived-At: Lars Ingebrigtsen writes: > + void (*destructor)(void*); Shouldn't this be formatted like: void (*destructor) (void *); instead? > + cache->spec = spec; I think this should be marked, since I don't see what protects the spec from garbage collection otherwise. Thanks.