unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Po Lu <luangruo@yahoo.com>
To: emacs-devel@gnu.org
Cc: Lars Ingebrigtsen <larsi@gnus.org>
Subject: Re: master 5141234acf: Refactor the webp cache code to allow usage by gif_load, too
Date: Mon, 11 Apr 2022 20:15:12 +0800	[thread overview]
Message-ID: <87bkx73jfz.fsf@yahoo.com> (raw)
In-Reply-To: <20220411113602.7A114C0581E@vcs2.savannah.gnu.org> (Lars Ingebrigtsen's message of "Mon, 11 Apr 2022 07:36:02 -0400 (EDT)")

Lars Ingebrigtsen <larsi@gnus.org> writes:

> +  void (*destructor)(void*);

Shouldn't this be formatted like:

  void (*destructor) (void *);

instead?

> +  cache->spec = spec;

I think this should be marked, since I don't see what protects the spec
from garbage collection otherwise.

Thanks.



       reply	other threads:[~2022-04-11 12:15 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <164967696186.12152.11548736665906939483@vcs2.savannah.gnu.org>
     [not found] ` <20220411113602.7A114C0581E@vcs2.savannah.gnu.org>
2022-04-11 12:15   ` Po Lu [this message]
2022-04-11 12:44     ` master 5141234acf: Refactor the webp cache code to allow usage by gif_load, too Lars Ingebrigtsen
2022-04-11 12:56       ` Po Lu
2022-04-11 13:04         ` Lars Ingebrigtsen
2022-04-11 13:12           ` Po Lu
2022-04-11 13:15             ` Lars Ingebrigtsen
2022-04-11 13:29               ` Po Lu
2022-04-11 13:58           ` Stefan Monnier
2022-04-11 14:55             ` Lars Ingebrigtsen
2022-04-11 13:12     ` Eli Zaretskii
2022-04-11 13:14       ` Lars Ingebrigtsen
2022-04-11 13:22         ` Eli Zaretskii
2022-04-11 13:25       ` Po Lu
2022-04-11 13:29         ` Eli Zaretskii
2022-04-11 13:32           ` Po Lu
2022-04-11 14:55       ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bkx73jfz.fsf@yahoo.com \
    --to=luangruo@yahoo.com \
    --cc=emacs-devel@gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).