From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: master e8488bcc9c: Avoid having font locking triggering unnecessary auto-saving Date: Mon, 09 May 2022 15:35:33 +0200 Message-ID: <87bkw67rru.fsf@gnus.org> References: <165191796540.22789.3432288633082546349@vcs2.savannah.gnu.org> <20220507100605.B7CA7C051FF@vcs2.savannah.gnu.org> <87fsli7uhf.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4410"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon May 09 15:55:38 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1no3rN-0000uo-Hj for ged-emacs-devel@m.gmane-mx.org; Mon, 09 May 2022 15:55:37 +0200 Original-Received: from localhost ([::1]:58046 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1no3rM-0004ZA-3q for ged-emacs-devel@m.gmane-mx.org; Mon, 09 May 2022 09:55:36 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52752) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1no3Y5-0007dz-WF for emacs-devel@gnu.org; Mon, 09 May 2022 09:35:46 -0400 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:60112) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1no3Y4-00027w-DN for emacs-devel@gnu.org; Mon, 09 May 2022 09:35:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=wEduH0EZt4Q+VC6NcNKpOkAMNfb7RAslo4cITqptm00=; b=HwJHTnilZ0S8a9ec7fLgygBe4W CMKN1IzUQNb0+fKD5JyGmfaWVMOseyJasl27WyVfvbk/382usgF7QZkIaG4w6bCPIORS4TX4zstM/ n4iY8xbin6PTjs4ZT0D1ui//FhKpP7aBwkIeEKcfv8a0xWc0XPkT0f4OxlC/MlIIaem4=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1no3Xy-0006LX-89; Mon, 09 May 2022 15:35:36 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwCAMAAABg3Am1AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAM1BMVEWBgnuSkouspZn9 /f3z8OrXyrdzdG15enJqa2Xf2dS0vt4+GhViXliEdnDKtp6tmHv///8jAvd+AAAAAWJLR0QQlbIN LAAAAAd0SU1FB+YFCQ0YNvxYDFYAAAGcSURBVEjHtdaNboQgDABgKNCCOnz/t13Lzw0UiC5bc+oF +WgRNSqlNf9A658dGGMNb7wD7eoZ0EppQKVJtcFnFIMaIA3Sxr0VcWA6dERRC0h/mlP4+kdQgnQB pUPtxgCpjwvoAweAEPKEZeYanwErQHZvgA3mOUjrcCsJOWagxj8B/TcZcAX4KoVtg22UgYbAmLDh 7jPARsyB3fb9uKzDvCT3FU3wu74u3BzsDPSOFciEl4A7mvNSEtaSaAD4JorHbQ5IC2APf9wmvQIG whuQYvA8rMHtXvoFaN8aDwBf1XdALuw7sMwQwsuSomsB5v7T27sH+S76gEcZPilmIITonB0+02Pg YnRQQClmXZKAWEEbTzJQHr0+DyNgY8oQYlNSWYgJgAzOmgGRJkBO+ALAgQBczwGvAG8A+/FbcF5A njSWMmvuDqhhBuwL7YAfgNsgd+B74NFzpJ0cD7BnjJAA+TYy8HVN6hgHhATOBqD0Tv8UeuJvD3bE HyCyFXBGBtZzs+IPEo0qfURwBuR3Yo082sGDg4DIQNryVs5+A3X/NZWE4oh1AAAAJXRFWHRkYXRl OmNyZWF0ZQAyMDIyLTA1LTA5VDEzOjI0OjU0KzAwOjAwDNCSYgAAACV0RVh0ZGF0ZTptb2RpZnkA MjAyMi0wNS0wOVQxMzoyNDo1NCswMDowMH2NKt4AAAAASUVORK5CYII= X-Now-Playing: Eurythmics's _Sweet Dreams (Are Made Of This)_: "This Is The House" In-Reply-To: (Stefan Monnier's message of "Mon, 09 May 2022 09:22:26 -0400") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:289533 Archived-At: Stefan Monnier writes: > I'm not completely surprised, to be honest. The handling of MODIFFs is > surprisingly delicate. Take a look at the code for > `Frestore_buffer_modified_p` to get an idea. Setting MODIFF back to > a previous value is something I would not recommend. Hm... /* Here we have a problem. SAVE_MODIFF is used here to encode buffer-modified-p (as SAVE_MODIFF=auto_save_modified we risk changing recent-auto-save-p from nil to t. */ SAVE_MODIFF = (NILP (flag) /* FIXME: This unavoidably sets recent-auto-save-p to nil. */ ? MODIFF /* Let's try to preserve recent-auto-save-p. */ : SAVE_MODIFF < MODIFF ? SAVE_MODIFF /* If SAVE_MODIFF == auto_save_modified == MODIFF, we can either decrease SAVE_MODIFF and auto_save_modified or increase MODIFF. */ : modiff_incr (&MODIFF)); (Ah, and FLAG isn't documented in the doc string, which perhaps it should be?) Well... would upping auto_save_modified to MODIFF in with-silent-modifications do the trick instead? (I mean, if recent-auto-save-p was already true when the macro was entered.) I.e., reverse which modiff we're twiddling here. Hm... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no