From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: Splitting some erc tests Date: Wed, 25 May 2022 03:13:24 +0200 Message-ID: <87bkvmfm8b.fsf@gnus.org> References: <87wneag2zc.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9297"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: "emacs-devel@gnu.org" To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed May 25 03:14:42 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ntfbl-0002DB-AH for ged-emacs-devel@m.gmane-mx.org; Wed, 25 May 2022 03:14:41 +0200 Original-Received: from localhost ([::1]:43094 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ntfbi-00027T-H7 for ged-emacs-devel@m.gmane-mx.org; Tue, 24 May 2022 21:14:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43728) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ntfai-0001Ql-BA for emacs-devel@gnu.org; Tue, 24 May 2022 21:13:36 -0400 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:59328) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ntfag-0005KX-LH for emacs-devel@gnu.org; Tue, 24 May 2022 21:13:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=P3bvZqOxsS6dcjjlltB7G5/zls1GeK2y3WHZHTGZju0=; b=Rav1WuEljRjbKHXFIiuQ8Bb1Nb f13zFytqFuT+adxsLtwa+KxU7GFS9ROUYXKNVSkj8GXGP5aPA4J0LZyLY0SINkTKuplYw0uEMrCNP pZzYfTelEkAoTsIfiYboSV68f2ofu6RxCa/Bu/VBwIG+IPQR80VwBDzuv73LV0bEEOWI=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ntfaZ-0004Lj-Dm; Wed, 25 May 2022 03:13:30 +0200 X-Now-Playing: William Basinski's _The Disintegration Loops_: "DLP 1.1" In-Reply-To: (Stefan Monnier's message of "Tue, 24 May 2022 15:59:26 -0400") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:290226 Archived-At: Stefan Monnier writes: > My bet is that they aren't. But IIRC the tests aren't run in the order > in which they appear in the file, so I suspect that in *most* cases they > are indeed sufficiently independent for your parallelism use-case. > And those that aren't should be fixed accordingly. I've done some slight testing, and it seems to work OK. I've extended ert-run-tests-batch-and-exit to take a "modulo" parameter to select the nth test, and then you can pass that in from the Makefile. However, I'm a bit lost as to how to express this stuff in the Makefile itself. If we're running without "-j", then we don't want to do this, but that information doesn't seem to be available without something like this? https://blog.jgc.org/2015/03/gnu-make-insanity-finding-value-of-j.html We'd also just want this for a select number of the tests, and the tests are run as such: %.log: %.elc $(AM_V_GEN)${MKDIR_P} $(dir $@) $(AM_V_at)HOME=$(TEST_HOME) $(emacs) \ -l ert ${ert_opts} -l $(testloadfile) \ $(TEST_RUN_ERT) What would be the most convenient way to have a different rule for a set of named tests? I was first thinking of the moral equivalent of %.log: %.elc for i in `seq $jobs`; do $(emacs) ... (ert-run-tests-batch-and-exit ... $i $jobs) & done > $*.log but that goes against the Make grain -- Make should control the parallelism, of course. So a number of rules like: %.log-1: %.elc $(emacs) ... (ert-run-tests-batch-and-exit ... $* $jobs) or something... but... this is way out of my Makefile comfort zone. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no