From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: master 28358db930 1/2: Fix loaddefs generation Date: Wed, 01 Jun 2022 18:50:55 +0800 Message-ID: <87bkvc8xo0.fsf@yahoo.com> References: <165407915849.23252.1559301725793524980@vcs2.savannah.gnu.org> <20220601102558.E4719C05808@vcs2.savannah.gnu.org> <875ylk3bqj.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36403"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jun 01 13:29:37 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nwMXf-0009Dj-Ma for ged-emacs-devel@m.gmane-mx.org; Wed, 01 Jun 2022 13:29:35 +0200 Original-Received: from localhost ([::1]:47394 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nwMXe-00088x-HC for ged-emacs-devel@m.gmane-mx.org; Wed, 01 Jun 2022 07:29:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53400) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nwLwe-0001Qn-0b for emacs-devel@gnu.org; Wed, 01 Jun 2022 06:51:46 -0400 Original-Received: from sonic306-20.consmr.mail.ne1.yahoo.com ([66.163.189.82]:33151) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nwLwb-0004MA-9p for emacs-devel@gnu.org; Wed, 01 Jun 2022 06:51:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1654080665; bh=5m5FcdgvuT23t45QtMIydE1AQ3jRS8DjEZiqPF7M9NU=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=Lp+95v/D+J+wl15dpOapVfVbjcJXf+T3xsl/BU9UrtPlPWI3pO19SWsQ5saoGheCuRSmHQgTsX1280b4TtqDKewQvHVYviMNeaXxvSQesawTSNilc4kQgDY2lLwKDA/mN2u+C/NRx0DNR2JE+XuWRS7EzvnqS+YfxQ5lr4nLVRU61CvNdymIoqClH7TqNgJh9WCOsp9ZlNvk5NGDeUqEcOd8zLbBkE5lty/+6jHh+cv74cqFdCARX9RPHSe3Ivro/inHWbPuQ+sG/gtzZk8kghibVT6bdPwuI573BiesygWohS7IQt4qaLhz7kaY6G/Ewc5swNhNuxWJQUj2I/TXcQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1654080665; bh=+4zQCT6qDJrHREID8MIIohGwTUBjB4Lc+zXZNmC9EP+=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=OWsPYhR9fXO3mz6Q8fvDHmBY651giXr5iDwv3r6KzGMiXptYeU/fb/XFqDCtHeeSLATjGo526l0+K4YJIMyuR4+GdicUc42/CeVVfwoabQG4Wr8ySiq9v9TX9PTmzt8sdIyF6K06JWWvmskhC3YD58j/274E5DczWt0uOpQNrBCw4w7MKVzj5KYR4nXtF0Djw67vpBBnPsaQ+3fqm2HT9UPwAigDOJHEt4sbnS7pw7bCogTLyPz9Vjm2Lv+q6cS95NXtxWhU4bpduSVH5iS/tJjVXuSVENNe6AEfq1SMcNryC5nwLAX3sC40cXphiDQyb9ZLnpGxIs4OMkLooOckOA== X-YMail-OSG: bJgu77cVM1nFZezsk2QKBe46xSdrPSCrBxOvmujUmp9Eqnkaxh56GHHAb.b7opv d8DJf3Qy7E3bCnZg_K6h1MwxVy7hWF2lvxggtbhlaopvg6p15DLDKivdaFcIyi8rH1wc48y1Djto 75I0zt0QYhLNv._oqgLEoftpF5zIRosU25G41p9hJRd5jjpi5AUGqhrUJ3H7IDuwTfOuyzhJHmht Gqkv0kdvfpQksro85HevYCsNDV6kj21nGOEwWXo8zn5X6f2CjcgIm3DDfJzZBOQiXrcbzC6Vi.sx tZ6iwfjqp4Ytu5kXk3nADw4BUF8VoZQJgT25eWqz7Ls0oT34ePhDF6b9LAhcRnYJOTlxsDcLhwFB 0jEjUpi4t2COHVvrz710OP.m4iuvNlOLoOttbyYcaQNbekjwQzWBp.29Cd.sbwrawZJn_yT.O5mk HqEYRA.Be5rw5jnShgCVUzhA5jo5VkuAFee0P4I_h40PbqbW4BnDf.Bn9GyglaIVpMLcUue8Jl9E P5b76cK07BPQ6LxYloIL6vVVEnUkMuWpepIf_wV.QTGlwYdxMAw0rnwwbPOAALi3mp9HiZPzzbAf GuOVgYwPe7aE1kdo9bum.nUtUv7wAhEsNfnCWsZay146.x117TOd7Kn3WwKGw0GaCxSG8H08PD2G .bjQdZRi5sOcT5_Hihyssz_9AS8jTLaNm.UOCgmmcEb0QMV0nMw2iJkENRoQSFfZ9NwwX1Qwtj2Q xEhJapmgolLgzq3kcnPSSJh7Kh8OhJ2u63p491OrnZ25u4kRR5wgNc9jQhMH5Rp04xZYFF3pJFH1 IwbtGp7dCNUxNi5fcF1zBdKuwFgW8SHk8pBhLYwudI X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic306.consmr.mail.ne1.yahoo.com with HTTP; Wed, 1 Jun 2022 10:51:05 +0000 Original-Received: by hermes--canary-production-sg3-5f7658c994-zbd6m (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID bb116de1af5c54fb202c122edb097ef1; Wed, 01 Jun 2022 10:51:00 +0000 (UTC) In-Reply-To: <875ylk3bqj.fsf@gnus.org> (Lars Ingebrigtsen's message of "Wed, 01 Jun 2022 12:43:32 +0200") X-Mailer: WebService/1.1.20225 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.189.82; envelope-from=luangruo@yahoo.com; helo=sonic306-20.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:290477 Archived-At: Lars Ingebrigtsen writes: > That will make delete-region be called with a nil if the search-forward > fails. But it shouldn't fail -- if it fails, there loaddefs file is > corrupted. The build kept failing with a `search-failed' error before this change. I don't know that code very well, but allowing it to fail did fix the bug. I'm not sure how to fix that properly. Would it suffice to simply not call `delete-region' should the search fail?