unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Robert Pluim <rpluim@gmail.com>
To: emacs-devel@gnu.org
Cc: Po Lu <luangruo@yahoo.com>
Subject: Re: master 1d681a5700: Add test for bug#56078 fix
Date: Tue, 21 Jun 2022 10:10:49 +0200	[thread overview]
Message-ID: <87bkumxwqe.fsf@gmail.com> (raw)
In-Reply-To: <20220621021220.E1FCFC01686@vcs2.savannah.gnu.org> (Po Lu via Mailing list for Emacs changes's message of "Mon, 20 Jun 2022 22:12:20 -0400 (EDT)")

>>>>> On Mon, 20 Jun 2022 22:12:20 -0400 (EDT), Po Lu via Mailing list for Emacs changes <emacs-diffs@gnu.org> said:

 
    Po> +(ert-deftest dnd-tests-open-remote-url ()
    Po> +  ;; Expensive test to make sure opening an FTP URL during
    Po> +  ;; drag-and-drop works.
    Po> +  :tags '(:expensive-test)
    Po> +  ;; Don't run this test if the FTP server isn't reachable.
    Po> +  (skip-unless (and (fboundp 'network-lookup-address-info)
    Po> +                    (network-lookup-address-info "ftp.gnu.org")))
    Po> +  ;; Make sure bug#56078 doesn't happen again.
    Po> +  (let ((url "ftp://anonymous@ftp.gnu.org/")
    Po> +        ;; This prints a bunch of annoying spaces to stdout.
    Po> +        (inhibit-message t))
    Po> +    (should (prog1 t (dnd-open-remote-url url 'private)))))
    Po> +
    Po>  (provide 'dnd-tests)
    Po>  ;;; dnd-tests.el ends here

I thought that the test suite 'phoning home' was frowned upon (and
which platform doesnʼt have network-lookup-address-info?)

Robert
-- 



       reply	other threads:[~2022-06-21  8:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <165577754064.962.4980616621155170793@vcs2.savannah.gnu.org>
     [not found] ` <20220621021220.E1FCFC01686@vcs2.savannah.gnu.org>
2022-06-21  8:10   ` Robert Pluim [this message]
2022-06-21 10:16     ` master 1d681a5700: Add test for bug#56078 fix Po Lu
2022-06-21 10:23       ` Robert Pluim
2022-06-21 12:11         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bkumxwqe.fsf@gmail.com \
    --to=rpluim@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=luangruo@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).