unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Philip Kaludercic <philipk@posteo.net>
Cc: Augusto Stoffel <arstoffel@gmail.com>,
	 Andreas Schwab <schwab@linux-m68k.org>,
	 emacs-devel@gnu.org
Subject: Re: Deprecation of define-key?
Date: Tue, 02 Aug 2022 12:46:03 +0200	[thread overview]
Message-ID: <87bkt2zzx0.fsf@gnus.org> (raw)
In-Reply-To: <87edxzc5v1.fsf@posteo.net> (Philip Kaludercic's message of "Tue,  02 Aug 2022 10:11:30 +0000")

Philip Kaludercic <philipk@posteo.net> writes:

> Why should this kind of indentation only be used for definition forms?
> I wouldn't consider `progn', `pcase', or `cl-callf' definitions, and
> they all have the `lisp-indent-function' property set.

But they're not normal functions.

> I believe the indentation that Augusto suggested is perfectly
> reasonable.

(keymap-set some-map
  "a" 'command-a)

looks pretty odd to me, and I think anybody reading such code would
assume that `keymap-set' is a macro doing something odd.




  reply	other threads:[~2022-08-02 10:46 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-29 15:33 Deprecation of define-key? Philip Kaludercic
2022-07-29 16:16 ` Andreas Schwab
2022-07-30 11:46   ` Philip Kaludercic
2022-07-30 11:51     ` Lars Ingebrigtsen
2022-07-31  6:48       ` Jean Louis
2022-07-31  7:14         ` Visuwesh
2022-08-02  9:44       ` Augusto Stoffel
2022-08-02  9:54         ` Philip Kaludercic
2022-08-02 10:01           ` Lars Ingebrigtsen
2022-08-02 10:06             ` Philip Kaludercic
2022-08-02 10:11               ` Lars Ingebrigtsen
2022-08-02 10:00         ` Lars Ingebrigtsen
2022-08-02 10:11           ` Philip Kaludercic
2022-08-02 10:46             ` Lars Ingebrigtsen [this message]
2022-08-02 10:14           ` Augusto Stoffel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bkt2zzx0.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=arstoffel@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=philipk@posteo.net \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).