From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Theodor Thornhill Newsgroups: gmane.emacs.devel Subject: Re: Suggesting that feature/tree-sitter be merged (was Re: Tree-sitter and major mode inheritance) Date: Sat, 19 Nov 2022 19:46:07 +0100 Message-ID: <87bkp2u6j4.fsf@thornhill.no> References: <0249C656-21C8-49F2-B979-A1894BF80637@gmail.com> <6DDC3B43-8B34-41A8-9BCA-77EEAD0EB124@gmail.com> <95C0B9E2-9C5B-4206-87D8-FA388DA3A1C8@thornhill.no> <83v8na7pww.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15707"; mail-complaints-to="usenet@ciao.gmane.io" Cc: casouri@gmail.com, jostein@kjonigsen.net, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Nov 19 19:47:15 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1owSrz-0003tz-9C for ged-emacs-devel@m.gmane-mx.org; Sat, 19 Nov 2022 19:47:15 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1owSrC-00011v-Ln; Sat, 19 Nov 2022 13:46:26 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1owSr9-00011T-HY for emacs-devel@gnu.org; Sat, 19 Nov 2022 13:46:23 -0500 Original-Received: from out0.migadu.com ([2001:41d0:2:267::]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1owSr5-0001Ox-Vp; Sat, 19 Nov 2022 13:46:21 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1668883574; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QhHqnKbByPkAymgOnSzuaU2V0aF6NorE/0ECefcIrCY=; b=tWh1DhlapMaL8tsSN6u1OF6cDZKwTMxo4JlwA8uA2cEf/bP1hWByps3CS44HMjCGpskzMW QXSpRdanMA7Cu7oV1pWo5kRzIQTfBsMXHLigfTUER4lEVC5rlpHs77k7pOj9Xlr3fLhlAl s/zawjuE2L3qH0/f//NIuQgPabiUCcHsoqstNwEXvC48l2wv9l2PHSJBzmrG9EjTojQLYk fWZ5AspNeJ19HYu+WJvow3YOBND8dVBqXiOrmsKcnBR1k3V9fTWw5wXZJClrz9VXpPnKSD u8G7apXX9PxBkBHh2z3IBTVjMOrOPBI6gb+TM3r9FWMAbX2RHf/Xkh+mVo8kug== In-Reply-To: <83v8na7pww.fsf@gnu.org> X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=2001:41d0:2:267::; envelope-from=theo@thornhill.no; helo=out0.migadu.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:300195 Archived-At: Eli Zaretskii writes: >> Date: Sat, 19 Nov 2022 06:21:12 +0100 >> From: Theodor Thornhill >> CC: emacs-devel , Eli Zaretskii >>=20 >> >The good news is, feature/tree-sitter is merging in a few days! And >> >we=E2=80=99ll make further improvements on the master. So rest assured!= :-) >> >I think we can at least get C, Python, Javascript, Typescript, Bash, >> >JONS and CSS to go with the up coming release, largely thanks to >> >Theo=E2=80=99s (and tree-sitter=E2=80=99s) productivity. I personally d= on=E2=80=99t know >> >enough of C++ and Java to polish them, but they have a good chance >> >too. >>=20 >> Java should be good to - modulo some tweaks. I'm using it daily at work = already :)=20 > > Btw, should we add C# to c-ts-mode.el? Or did we already discuss that and > decided against? I don't remember, sorry. I don't think we decided against, and we didn't really discuss it. IIRC your "challenge" was for the cc modes already included in emacs, and C# is not that. But seeing how there's a functioning cc-based c#-mode, I could tweak that to include both. The Cc mode variant is very stable and have been for some time already. There's no need to maintain the one in ELPA, and as I'm the author of it I think we can merge both? So we can have in-tree support for c# whether or not you have tree-sitter enabled? I can whip up a patch for that if you want, or we could just add the tree-sitter variant. In any case, I think c#-mode should probably not be inside of c-ts-mode, considering that it's not a superset of C, like C++, but its own entity. What do you think?