From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sean Whitton Newsgroups: gmane.emacs.devel Subject: Re: master a30781399b3: * subr-x (eval-command-interactive-spec): New function. Date: Wed, 14 Jun 2023 11:18:20 +0100 Message-ID: <87bkhi5our.fsf@melete.silentflame.com> References: <83r0qq3zo3.fsf@gnu.org> <87edmog836.fsf@melete.silentflame.com> <83r0qo3ioj.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28003"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jun 14 12:18:51 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q9NaT-00071K-Db for ged-emacs-devel@m.gmane-mx.org; Wed, 14 Jun 2023 12:18:50 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q9Na7-0002cK-27; Wed, 14 Jun 2023 06:18:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q9Na6-0002c4-7H for emacs-devel@gnu.org; Wed, 14 Jun 2023 06:18:26 -0400 Original-Received: from wout3-smtp.messagingengine.com ([64.147.123.19]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q9Na4-0000MR-MN; Wed, 14 Jun 2023 06:18:25 -0400 Original-Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id B617D32009BB; Wed, 14 Jun 2023 06:18:22 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Wed, 14 Jun 2023 06:18:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1686737902; x= 1686824302; bh=Bpj+g5YrqT39tRti82k+VZWGhA2e8mdN6LOv7YkfwqY=; b=d BvHhSI7SHNDmY7rW/Jg+gk0Gkc7dyNsrIcqdeJpUAPNe5au+i56/RPd0eFsCtcMw Rqls1N/qNTbj5bWCcPfrzUu4sYMW1R51XXcKaORzEgvF+NOjscxtjxfsG/fkCs5b mUsXyXS4Vtt1lTLqKq01STqTSUcuwDFnL+8tNqh+/OCFY5fHxJvm/1hBToavgk9W 4mIYolkG2wVJ+I+TjHidSriWW37nsOvjGDC7zRRZqWiaWNCjhJm0Ah54FlZFtUEw EzF/Wdr/8d7x0HkO7uT/2mS6kn28yEx5QFa3EroAVxda4Li7YGK7rHtRlBgd4UHY /uWcpMURJnvTtYNBOn0zw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1686737902; x=1686824302; bh=Bpj+g5YrqT39t Rti82k+VZWGhA2e8mdN6LOv7YkfwqY=; b=i5OZeG4TbyyVgpXEt8s3cD1vJbX5o dISwIyGLFNGF5UCV4LYMwej1gtlztQCuaO68rOVXRnLwgVGYZtx1tm+SP5hyFaL3 LDJTNwrZCxp7ox/OHa9H4IfoPlgQb2/R8lUEJWRH9CNs53Bp9GwWgtwtLgqE1qfA S6B6YlAmB3LrnSqZ8Qj0/u4NFzXhKNOZsCSrWcLbKt+EluSG0FoO1FJcwdCLWtjT 5Rqn16o/KcY3U/VF7qPfhNf4nD+gRxHmn6ZXFzNSJvhDrrk6tgqszX1d931/7TqD L8q6nN3XP15DI3RC1dh94wQnrdC+H7lkUMps9yLY4VYjb4MvXCM0SbP8Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgedvtddgvdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefujghffffkfgggtgesthdttddttdertdenucfhrhhomhepufgvrghn ucghhhhithhtohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgvqe enucggtffrrghtthgvrhhnpedtffdvffeuleeuvdetkedvveehgfehvdegvefghfevudek geegleevgeejkeetkeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 14 Jun 2023 06:18:21 -0400 (EDT) Original-Received: by melete.silentflame.com (Postfix, from userid 1000) id 239707E1571; Wed, 14 Jun 2023 11:18:20 +0100 (BST) In-Reply-To: <83r0qo3ioj.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 06 Jun 2023 14:59:40 +0300") Received-SPF: pass client-ip=64.147.123.19; envelope-from=spwhitton@spwhitton.name; helo=wout3-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:306793 Archived-At: Hello, On Tue 06 Jun 2023 at 02:59PM +03, Eli Zaretskii wrote: > My primary concern is about documenting useful features. In which > files to put the implementation is secondary, from my POV. We don't > need to be 110% consistent in this regard, btw. Okay. I'll add it to the manual if we decide we're keeping it. >> Regarding NEWS, CONTRIBUTE says >> >> There is no need to mention files such as NEWS and MAINTAINERS, or to >> indicate regeneration of files such as 'lib/gnulib.mk', in the >> ChangeLog entry. "There is no need" means you don't have to, but you >> can if you want to. >> >> Should that text perhaps be updated? > > Why? the last sentence already covers my request, doesn't it? It seemed to me that the text should say that it's considered preferable to mention them. The current text leaves it wholly up to an individual's inclination. >> > As for the name of the new function: what do people think about >> > renaming it to eval-interactive-spec? I don't think we need the >> > "command" part. >> >> In that case, what would we rename advice-eval-interactive-spec to, when >> we drop the 'advice-' prefix? > > That function exists for quite some time, so renaming it is a much > harder decision. If we decide not to rename it, wouldn't it then be confusing to have advice-eval-interactive-spec and eval-interactive-spec taking different kinds of argument, with no indication in their name about the difference? -- Sean Whitton