From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jack Kamm Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] python.el: Returning inferior Python output without inhibiting it Date: Sun, 15 Oct 2023 17:27:45 -0700 Message-ID: <87bkczif7i.fsf@gmail.com> References: <87msx2ib0c.fsf@gmail.com> <83fs2u8ehy.fsf@gnu.org> <87jzs6hz26.fsf@gmail.com> <837co58t8h.fsf@gnu.org> <83v8bp6m45.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33220"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Eli Zaretskii , kobarity Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Oct 16 02:28:55 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qsBTa-0008RG-Fv for ged-emacs-devel@m.gmane-mx.org; Mon, 16 Oct 2023 02:28:54 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qsBSZ-0002Da-Hh; Sun, 15 Oct 2023 20:27:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qsBSX-0002DI-O7 for emacs-devel@gnu.org; Sun, 15 Oct 2023 20:27:49 -0400 Original-Received: from mail-oo1-xc30.google.com ([2607:f8b0:4864:20::c30]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qsBSW-0007aD-At; Sun, 15 Oct 2023 20:27:49 -0400 Original-Received: by mail-oo1-xc30.google.com with SMTP id 006d021491bc7-57bbb38d5d4so2246391eaf.2; Sun, 15 Oct 2023 17:27:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697416066; x=1698020866; darn=gnu.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=Hj1wHWHZIFT+KOGgcdRnUex23FtTWniJ0x28PwonvgQ=; b=BOkBFJ7IHAhBHNzeDfeBDaSQoDDu+xk9+66hS5hfekM/TGXA+i56CGb4mpnwyALRZU vKgQ+vgw9yGCQd5+u/yGb8YzXilXFnc85ET875HwAk81uHrwkZpEhPeN3YOGGKmzvxtg W2LPDX06/ZL+C3Qb2jK+2SumhJoqGg99BuAOsfmE9vyX6JD+acYecg76oDMOYPqwDXR1 jzVKUbk+WvEClfQO3FP7Zlb4UcTHIc2yYL8K15pmCg0fpcC3BVzcJvvRQnMB8+6Honat HMRxOQ6dIx68iJVOOTUtxIGnjpzuXGQRWolO9hXdnDSUxwLtg0RttU164LgVvVMQoN/u FiJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697416066; x=1698020866; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Hj1wHWHZIFT+KOGgcdRnUex23FtTWniJ0x28PwonvgQ=; b=UmVxVPKj8vCQ0tAe1ICFDi1g1JW25USlVdA35rN6swv/YiXPMAJ5zEh7mBRY2G9byL zolSKbhtFMgKNrzBxJpkwvn9aIoYkO8eMC/+bgCme+MC3oZU4tDFiPt1RGOEWKCU0Knz eWSPdzm63SYL7iD/rdbLRn/QybM1GZudnpjuUyk658UuPJaO6WGeOcSk5YRW3lEUBg0D a2WRtfWoDj4rpcYiqMQccr3sj9zVhIm72R0urh1l7M+XUt0R8n9tUOOpy8XWXogcEWcL 8OOthmvn3m6aYV/uKNYiEx7by8oVzqmd7HQPxh3122jcieFiBnUB2exjdjCfQKzOdjJ9 RfhA== X-Gm-Message-State: AOJu0YwM0ik1me8ePDCi0mvDXc6ZK8CxGLJg6iCv2KSguunjayr0gCBW Oiay9Tmh8+Wo+L0Y7c/ei5b8pVjnFgg= X-Google-Smtp-Source: AGHT+IFzJrhgbjgbnvrx/oSKqu5m9EQVgxwBJ9aCO7oHuecL+e5iH+zeD3qa/i4via3NPS873raE3w== X-Received: by 2002:a05:6358:1ca:b0:134:de8b:17f0 with SMTP id e10-20020a05635801ca00b00134de8b17f0mr35235568rwa.19.1697416066475; Sun, 15 Oct 2023 17:27:46 -0700 (PDT) Original-Received: from localhost (157-131-78-143.fiber.dynamic.sonic.net. [157.131.78.143]) by smtp.gmail.com with ESMTPSA id p3-20020aa79e83000000b006926506de1csm1668459pfq.28.2023.10.15.17.27.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Oct 2023 17:27:45 -0700 (PDT) In-Reply-To: <83v8bp6m45.fsf@gnu.org> Received-SPF: pass client-ip=2607:f8b0:4864:20::c30; envelope-from=jackkamm@gmail.com; helo=mail-oo1-xc30.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:311502 Archived-At: Eli Zaretskii writes: > Thanks. I will wait for a few days to give others a chance to chime > in and post comments or suggestions, and will install this after that, > barring any objections. Since submitting this patch, I started to have doubts that `python-shell-send-string-maybe-output' is suitable for ob-python. So, I suggest not to merge this after all, since ob-python was the main motivating use case. The reason is that `python-shell-send-string-no-output' can end prematurely if the output contains a substring that looks like a prompt, and ob-python should remain robust to this edge case -- it's not too far-fetched that some user code executed by ob-python would produce a substring like ">>>".