From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: ELPA submission: plz-see Date: Tue, 31 Oct 2023 08:43:33 +0000 Message-ID: <87bkcfw5ai.fsf@posteo.net> References: <87y1fkbmut.fsf@gmail.com> <83y1fk9vcu.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7960"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Augusto Stoffel , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Oct 31 10:10:38 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qxklf-0001mc-6D for ged-emacs-devel@m.gmane-mx.org; Tue, 31 Oct 2023 10:10:35 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qxkke-0008NF-5v; Tue, 31 Oct 2023 05:09:32 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qxkkb-00081K-Hv for emacs-devel@gnu.org; Tue, 31 Oct 2023 05:09:29 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qxkkZ-0008Kg-3U for emacs-devel@gnu.org; Tue, 31 Oct 2023 05:09:29 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 8DEA3240101 for ; Tue, 31 Oct 2023 10:09:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1698743363; bh=mGq9VhOW39t4jerkIQk92Hz25ATIKaROEaiAnQm5aiM=; h=From:To:Cc:Subject:Date:Message-ID:Autocrypt:MIME-Version:From; b=ReILZ1QvdKLXrOQguVo1xkGkwSX820KvBCpWBM4+p39u5f27+7jzsEXal1A9vGZGd Qjw6FdMNBcu4K7GdGJx+gCahE6ET4Ob0xMhiXv8abwBExaGxaKFnay4Mq0ivjpQtto thYhO0XjLGtbeiKJcnT8yucTcvgR3maDiw1HWF6cmCJQwNlO7JrUc7P80aUJ24lTD2 BR9WI6qpQ+Xt0ctjfKAfGnQqc6iOfDskLVG5e+0cC8b/1wjrL4F1CPoNv2T6Wx/nq2 tMQqHkPWuTC3o3/ALMsNsWGUMT0ODfjou111LGGQZcZKqTf39veQ02n3fcF2Z8q2/n PBUnB4YwKtWwQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4SKPTZ5h3Rz6tsf; Tue, 31 Oct 2023 10:09:22 +0100 (CET) In-Reply-To: <83y1fk9vcu.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 30 Oct 2023 13:56:49 +0200") X-Hashcash: 1:20:231031:emacs-devel@gnu.org::wJiDodMtMaeYGhbm:Xv4 X-Hashcash: 1:20:231031:eliz@gnu.org::Zjcyi3VZ2tSDbQZL:Y3S X-Hashcash: 1:20:231031:arstoffel@gmail.com::m38xISB26+bWGTUa:1Zvh Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:312014 Archived-At: --=-=-= Content-Type: text/plain Eli Zaretskii writes: >> From: Augusto Stoffel >> Date: Mon, 30 Oct 2023 08:17:30 +0100 >> >> I would like to submit the following package to ELPA: >> >> https://github.com/astoff/plz-see.el Loks good, I only have a few comments: --=-=-= Content-Type: text/plain Content-Disposition: inline diff --git a/plz-see.el b/plz-see.el index 2e5451f..74d62b1 100644 --- a/plz-see.el +++ b/plz-see.el @@ -4,6 +4,8 @@ ;; Author: Augusto Stoffel ;; Keywords: comm, network, http +;; Version: 1.0.0 +;; Package-Requires: ((emacs "29.1")) ;; This program is free software; you can redistribute it and/or modify ;; it under the terms of the GNU General Public License as published by @@ -20,10 +22,12 @@ ;;; Commentary: -;; +;; Please write a brief commentary section, that is useful when +;; querying the package from a `describe-package' buffer. ;;; Code: +(eval-when-compile (require 'cl-lib)) (require 'json) (require 'plz) @@ -57,7 +61,7 @@ If nil, never delete old response buffers." (defcustom plz-see-display-action nil "The ACTION argument `plz-see' passes to `display-buffer'." - :type 'sexp) + :type display-buffer--action-custom-type) (defcustom plz-see-header-line-format (let ((headers '(plz-see-header-line-status @@ -181,7 +185,7 @@ call and AS specifies the argument type they expect." ('response response) ('buffer buffer) ((or 'binary 'string 'file `(file ,_)) - (user-error "plz-see does not accept :as %s" as)) + (user-error "`plz-see' does not accept :as %s" as)) ((pred functionp) (with-temp-buffer (insert (plz-response-body response)) --=-=-= Content-Type: text/plain >> It is an interactive HTTP client in the sense that request responses are >> pretty-printed in a pop-up buffer. It is useful e.g. to test REST APIs. > > I wonder if you could come up with a name that tells something about > the package's purpose. "plz-see" tells me "please see", and I don't > see any relation to HTTP, REST, pretty-printing, or popup buffers. I agree, from what I see this is just an implementation detail. Plz is a peculiar enough name as it is, it shouldn't be inherited by packages that depend on it. Or is there any reason why the package couldn't also use url.el? -- Philip Kaludercic --=-=-=--