From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New package devicetree-ts-mode Date: Fri, 22 Dec 2023 07:36:51 +0000 Message-ID: <87bkaiadt8.fsf@posteo.net> References: <874jgb5tx8.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22421"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Aleksandr Vityazev Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Dec 22 08:37:37 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rGa6C-0005a6-9a for ged-emacs-devel@m.gmane-mx.org; Fri, 22 Dec 2023 08:37:36 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rGa5b-0007BX-TV; Fri, 22 Dec 2023 02:37:00 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rGa5Z-0007BH-Qp for emacs-devel@gnu.org; Fri, 22 Dec 2023 02:36:57 -0500 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rGa5W-0003AX-Ln for emacs-devel@gnu.org; Fri, 22 Dec 2023 02:36:57 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 36D2F240101 for ; Fri, 22 Dec 2023 08:36:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1703230612; bh=flCX4gkpHG/aw/DRpPQjLnIvKM8TwqtW2Hexxmb8gQg=; h=From:To:Cc:Subject:Autocrypt:OpenPGP:Date:Message-ID:MIME-Version: From; b=LdAixgFGSdarnwv29mcwjqMIpF3x2XHg2eyEb401ibFF6RQLJc7R9E2KkahDomPBC lmV1buKNLaFs7c+UK+T/aqb4U5QioMzq66SzrJSUPBCDliqEQvC7LTlWhRrz83Z0vu 5W9UZ5iIaIX78jqHFfLy/TDFvVDhOxaPIwhcNJUKfcptSCrBLKQ9NCiiSX6DmEfwjU U4X38xXBC3ZN48ILlSR7339RYT2YHRJkYcE8g/zZ5qLxyQ5onS5e4irxhH/WxUxmGl 4r3+ZJ2utH3CGtgc1oUO306I8ZCUgNtOyHe/uRhsqWhdnC5pMC7gKk/zSWPiijiOgY rdzxcwZcfEatQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4SxJyq5lyYz6tx0; Fri, 22 Dec 2023 08:36:51 +0100 (CET) In-Reply-To: <874jgb5tx8.fsf@gmail.com> (Aleksandr Vityazev's message of "Thu, 21 Dec 2023 20:47:47 +0300") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:314057 Archived-At: --=-=-= Content-Type: text/plain Aleksandr Vityazev writes: > Hello, > > I'd like to submit devicetree-ts-mode [1] to GNU ELPA. > This is tree-sitter major mode for Devicetree [2] files. > > [1] https://git.sr.ht/~akagi/devicetree-ts-mode/ > [2] https://www.devicetree.org/ Here are a few comments: --=-=-= Content-Type: text/plain Content-Disposition: inline diff --git a/devicetree-ts-mode.el b/devicetree-ts-mode.el index 1d9f72c..d26937c 100644 --- a/devicetree-ts-mode.el +++ b/devicetree-ts-mode.el @@ -33,6 +33,7 @@ ;; * IMenu ;; * Font Lock +;; The commentary section could elaborate on what "Devicetree" are. ;;; Code: @@ -44,15 +45,21 @@ (declare-function treesit-parser-create "treesit.c") (declare-function treesit-node-child-by-field-name "treesit.c") +(defgroup devicetree () + "Tree-sitter support for DTS." + :prefix "devicetree-ts-" + :group 'languages) + (defcustom devicetree-ts-mode-indent-offset 4 "Number of spaces for each indentation step in `devicetree-ts-mode'." :version "29.1" + ;; This is not a core package, the version of your package is 0.2, + ;; so this doesn't match up :type 'natnum - :safe 'natnump - :group 'devicetree) + :safe 'natnump) ;; Taken from the dts-mode -(defvar devicetree-ts-mode--syntax-table +(defvar devicetree-ts-mode-syntax-table (let ((table (make-syntax-table))) (modify-syntax-entry ?< "(>" table) @@ -81,6 +88,10 @@ (defvar devicetree-ts-mode--indent-rules (let ((offset devicetree-ts-mode-indent-offset)) + ;; If this is a variable, that is set when the package is loaded, + ;; customising the user option `devicetree-ts-mode-indent-offset' + ;; will have no effect. You could turn this into a function + ;; instead. `((devicetree ((node-is ">") parent-bol 0) ((node-is "]") parent-bol 0) @@ -93,13 +104,14 @@ (no-node parent-bol 0)))) "Tree-sitter indent rules for `devicetree-ts-mode'.") +;; Could these be defconst? (defvar devicetree-ts-mode--treesit-keywords '("/delete-node/" "/delete-property/" "#define" "#include" "/omit-if-no-ref/" "/dts-v1/")) (defvar devicetree-ts-mode--treesit-operators - '( "!" "~" "-" "+" "*" "/" "%" "||" "&&" "|" - "^" "&" "==" "!=" ">" ">=" "<=" ">" "<<" ">>")) + '("!" "~" "-" "+" "*" "/" "%" "||" "&&" "|" + "^" "&" "==" "!=" ">" ">=" "<=" ">" "<<" ">>")) (defvar devicetree-ts-mode--font-lock-settings (treesit-font-lock-rules @@ -154,8 +166,8 @@ (defun devicetree-ts-mode--node-addresses (node) "List of addresses for NODE." - (reverse - (seq-reduce + (reverse ;Why `reverse'? (or `nreverse'?) + (seq-reduce ;Isn't this a `seq-filter'? (lambda (acc children) (if (string-equal (treesit-node-field-name children) "address") @@ -175,8 +187,6 @@ ;;;###autoload (define-derived-mode devicetree-ts-mode prog-mode "DTS" "Major mode for editing devicetree, powered by tree-sitter." - :group 'devicetree - :syntax-table devicetree-ts-mode--syntax-table (when (treesit-ready-p 'devicetree) (treesit-parser-create 'devicetree) @@ -187,7 +197,7 @@ ;; Imenu. (setq-local treesit-simple-imenu-settings - `((nil "\\`node\\'" + `((nil ,(rx bos "node" eos) nil devicetree-ts--mode--name-function))) (setq-local which-func-functions nil) @@ -216,9 +226,8 @@ (treesit-major-mode-setup))) -(if (treesit-ready-p 'devicetree) - (add-to-list 'auto-mode-alist - '("\\.dtsi?\\'" . devicetree-ts-mode))) +(when (treesit-ready-p 'devicetree) + (add-to-list 'auto-mode-alist '("\\.dtsi?\\'" . devicetree-ts-mode))) (provide 'devicetree-ts-mode) ;;; devicetree-ts-mode.el ends here --=-=-= Content-Type: text/plain > > From b69687be8232cfd305893b7c0b6999e6667d6dd8 Mon Sep 17 00:00:00 2001 > Message-ID: > From: Aleksandr Vityazev > Date: Wed, 20 Dec 2023 15:28:35 +0300 > Subject: [PATCH] * elpa-packages (devicetree-ts-mode): New package > > --- > elpa-packages | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/elpa-packages b/elpa-packages > index 612bc676cd..6f86a59cfd 100644 > --- a/elpa-packages > +++ b/elpa-packages > @@ -207,6 +207,8 @@ > :news "CHANGELOG.org" > :readme "README.md") > (devdocs :url "https://github.com/astoff/devdocs.el") > + (devicetree-ts-mode :url "https://sr.ht/~akagi/devicetree-ts-mode" > + :ignored-files ("LICENSE")) You can track this file in an .elpaignore file, within your repository (which you appear to have anyway). > (dict-tree :url nil) ;"http://www.dr-qubit.org/git/predictive.git" > (diff-hl :url "https://github.com/dgutov/diff-hl.git") > (diffview :url "https://github.com/mgalgs/diffview-mode.git") > > base-commit: b7bbd439862f2a58151eacacebc1815b7ddf3322 > -- > 2.41.0 --=-=-=--