Re: master 8074c08cd55: Use proper smime-keys entry for S/MIME signatures using OpenSSL

Re: master 8074c08cd55: Use proper smime-keys entry for S/MIME signatures using OpenSSL

[Robert Pluim]

>>>>> On Tue, 14 May 2024 10:45:08 -0400 (EDT), Eric Abrahamsen <eric@ericabrahamsen.net> said:

    Eric> branch: master
    Eric> commit 8074c08cd553ab6ee5ffe61cc2e56fb1e0a4fe34
    Eric> Author: Illia Ostapyshyn <illia@yshyn.com>
    Eric> Commit: Eric Abrahamsen <eric@ericabrahamsen.net>
 
    Eric> -(defun mml-smime-openssl-sign (_cont)
    Eric> -  (when (null smime-keys)
    Eric> -    (customize-variable 'smime-keys)
    Eric> -    (error "No S/MIME keys configured, use customize to add your key"))
    Eric> -  (smime-sign-buffer (cdar smime-keys))
    Eric> +(defun mml-smime-openssl-sign (cont)
    Eric> +  (smime-sign-buffer
    Eric> +   ;; List with key and certificate as its car, and a list of additional
    Eric> +   ;; certificates to include in its cadr for smime-sign-region
    Eric> +   (list
    Eric> +    (cdr (assq 'keyfile cont))
    Eric> +    (mapcar #'cdr (cl-remove-if-not (apply-partially #'equal 'chainfile)
    Eric> +                                    cont
    Eric> +                                    :key #'car-safe))))

Minor grumble:

  ELC      gnus/mml-smime.elc

In end of data:
gnus/mml-smime.el:138:20: Warning: the function ‘cl-remove-if-not’ might not be defined at runtime.

In reality 'cl-lib' will almost certainly already be loaded by anyone
using gnus, but any warning that can be avoided should be.

Robert
-- 

Re: master 8074c08cd55: Use proper smime-keys entry for S/MIME signatures using OpenSSL

[Eric Abrahamsen]

On 05/14/24 18:20 PM, Robert Pluim wrote:
>>>>>> On Tue, 14 May 2024 10:45:08 -0400 (EDT), Eric Abrahamsen <eric@ericabrahamsen.net> said:
>
>     Eric> branch: master
>     Eric> commit 8074c08cd553ab6ee5ffe61cc2e56fb1e0a4fe34
>     Eric> Author: Illia Ostapyshyn <illia@yshyn.com>
>     Eric> Commit: Eric Abrahamsen <eric@ericabrahamsen.net>
>  
>     Eric> -(defun mml-smime-openssl-sign (_cont)
>     Eric> -  (when (null smime-keys)
>     Eric> -    (customize-variable 'smime-keys)
>     Eric> -    (error "No S/MIME keys configured, use customize to add your key"))
>     Eric> -  (smime-sign-buffer (cdar smime-keys))
>     Eric> +(defun mml-smime-openssl-sign (cont)
>     Eric> +  (smime-sign-buffer
>     Eric> +   ;; List with key and certificate as its car, and a list of additional
>     Eric> +   ;; certificates to include in its cadr for smime-sign-region
>     Eric> +   (list
>     Eric> +    (cdr (assq 'keyfile cont))
>     Eric> +    (mapcar #'cdr (cl-remove-if-not (apply-partially #'equal 'chainfile)
>     Eric> +                                    cont
>     Eric> +                                    :key #'car-safe))))
>
> Minor grumble:
>
>   ELC      gnus/mml-smime.elc
>
> In end of data:
> gnus/mml-smime.el:138:20: Warning: the function ‘cl-remove-if-not’
> might not be defined at runtime.

That's odd, mml-smime.el has "(eval-when-compile (require 'cl-lib))",
and I didn't see that warning when compiling.

> In reality 'cl-lib' will almost certainly already be loaded by anyone
> using gnus, but any warning that can be avoided should be.

Agreed! I'm confused about this one, though.

Re: master 8074c08cd55: Use proper smime-keys entry for S/MIME signatures using OpenSSL

[Robert Pluim]

>>>>> On Tue, 14 May 2024 12:52:23 -0700, Eric Abrahamsen <eric@ericabrahamsen.net> said:

    >> 
    >> Minor grumble:
    >> 
    >> ELC      gnus/mml-smime.elc
    >> 
    >> In end of data:
    >> gnus/mml-smime.el:138:20: Warning: the function ‘cl-remove-if-not’
    >> might not be defined at runtime.

    Eric> That's odd, mml-smime.el has "(eval-when-compile (require 'cl-lib))",
    Eric> and I didn't see that warning when compiling.

    >> In reality 'cl-lib' will almost certainly already be loaded by anyone
    >> using gnus, but any warning that can be avoided should be.

    Eric> Agreed! I'm confused about this one, though.

`cl-remove-if-not' is in "cl-seq", not in "cl-lib", but itʼs
autoloaded, so Iʼm confused as well.

Adding (require 'cl-seq) to mml-smime.el fixes the warning, but I
donʼt think thatʼs the right thing to do.

Robert
-- 

Re: master 8074c08cd55: Use proper smime-keys entry for S/MIME signatures using OpenSSL

[Andreas Schwab]

On Mai 14 2024, Eric Abrahamsen wrote:

> On 05/14/24 18:20 PM, Robert Pluim wrote:
>> Minor grumble:
>>
>>   ELC      gnus/mml-smime.elc
>>
>> In end of data:
>> gnus/mml-smime.el:138:20: Warning: the function ‘cl-remove-if-not’
>> might not be defined at runtime.
>
> That's odd, mml-smime.el has "(eval-when-compile (require 'cl-lib))",

But that means that cl-lib isn't guaranteed to be loaded at runtime, and
cl-remove-if-not is not a macro.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."

Re: master 8074c08cd55: Use proper smime-keys entry for S/MIME signatures using OpenSSL

[Robert Pluim]

>>>>> On Wed, 15 May 2024 11:22:43 +0200, Andreas Schwab <schwab@suse.de> said:

    Andreas> On Mai 14 2024, Eric Abrahamsen wrote:
    >> On 05/14/24 18:20 PM, Robert Pluim wrote:
    >>> Minor grumble:
    >>> 
    >>> ELC      gnus/mml-smime.elc
    >>> 
    >>> In end of data:
    >>> gnus/mml-smime.el:138:20: Warning: the function ‘cl-remove-if-not’
    >>> might not be defined at runtime.
    >> 
    >> That's odd, mml-smime.el has "(eval-when-compile (require 'cl-lib))",

    Andreas> But that means that cl-lib isn't guaranteed to be loaded at runtime, and
    Andreas> cl-remove-if-not is not a macro.

Yes, but `cl-remove-if-not' is autoloaded. I guess the byte compiler
doesnʼt know that.

Robert
-- 

Re: master 8074c08cd55: Use proper smime-keys entry for S/MIME signatures using OpenSSL

[Andreas Schwab]

On Mai 15 2024, Robert Pluim wrote:

>>>>>> On Wed, 15 May 2024 11:22:43 +0200, Andreas Schwab <schwab@suse.de> said:
>
>     Andreas> On Mai 14 2024, Eric Abrahamsen wrote:
>     >> On 05/14/24 18:20 PM, Robert Pluim wrote:
>     >>> Minor grumble:
>     >>> 
>     >>> ELC      gnus/mml-smime.elc
>     >>> 
>     >>> In end of data:
>     >>> gnus/mml-smime.el:138:20: Warning: the function ‘cl-remove-if-not’
>     >>> might not be defined at runtime.
>     >> 
>     >> That's odd, mml-smime.el has "(eval-when-compile (require 'cl-lib))",
>
>     Andreas> But that means that cl-lib isn't guaranteed to be loaded at runtime, and
>     Andreas> cl-remove-if-not is not a macro.
>
> Yes, but `cl-remove-if-not' is autoloaded.

Note before cl-lib is loaded.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."

Re: master 8074c08cd55: Use proper smime-keys entry for S/MIME signatures using OpenSSL

[Eric Abrahamsen]

Andreas Schwab <schwab@suse.de> writes:

> On Mai 15 2024, Robert Pluim wrote:
>
>>>>>>> On Wed, 15 May 2024 11:22:43 +0200, Andreas Schwab <schwab@suse.de> said:
>>
>>     Andreas> On Mai 14 2024, Eric Abrahamsen wrote:
>>     >> On 05/14/24 18:20 PM, Robert Pluim wrote:
>>     >>> Minor grumble:
>>     >>> 
>>     >>> ELC      gnus/mml-smime.elc
>>     >>> 
>>     >>> In end of data:
>>     >>> gnus/mml-smime.el:138:20: Warning: the function ‘cl-remove-if-not’
>>     >>> might not be defined at runtime.
>>     >> 
>>     >> That's odd, mml-smime.el has "(eval-when-compile (require 'cl-lib))",
>>
>>     Andreas> But that means that cl-lib isn't guaranteed to be loaded at runtime, and
>>     Andreas> cl-remove-if-not is not a macro.
>>
>> Yes, but `cl-remove-if-not' is autoloaded.
>
> Note before cl-lib is loaded.

I'm not quite sure what that means, but it sounds like what we need here
is a straight `require'. I note that that's what other libraries that
use these cl function do.

Eric