unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Robert Pluim <rpluim@gmail.com>
To: Philip Kaludercic <philipk@posteo.net>
Cc: emacs-devel@gnu.org
Subject: Re: emacs-30 768e92b9c02: Update options that depend on 'which-key-dont-use-unicode'
Date: Thu, 11 Jul 2024 11:40:11 +0200	[thread overview]
Message-ID: <87bk34i7wk.fsf@gmail.com> (raw)
In-Reply-To: <87jzie2n20.fsf@posteo.net> (Philip Kaludercic's message of "Mon,  24 Jun 2024 18:49:43 +0000")

>>>>> On Mon, 24 Jun 2024 18:49:43 +0000, Philip Kaludercic <philipk@posteo.net> said:
    >> That works for me, although I wonʼt claim to understand why 😀

    Philip> My reasoning is that this will only run the setter if the value is
    Philip> /changed/, right?  So if we set `which-key-dont-use-unicode' is set
    Philip> before we load which-key, then the user option inherits the
    Philip> configuration and the other two options use the current value to
    Philip> determine their default value.  If on the other hand we change the user
    Philip> option after which-key has been loaded, then the custom setter will take
    Philip> effect, and will re-load the default value, which has previously been
    Philip> set to the (if ...) expression, as was the case before.

I spoke too soon, or my testing was wrong, Iʼm still getting
`which-key-separator' as nil when I customize
`which-key-dont-use-unicode' to nil in emacs-30.

Do you want a M-x report-emacs-bug?

Robert
-- 



  reply	other threads:[~2024-07-11  9:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <171921519771.16563.15139426619834982564@vcs2.savannah.gnu.org>
     [not found] ` <20240624074638.294E1C1FB6E@vcs2.savannah.gnu.org>
2024-06-24 14:32   ` emacs-30 768e92b9c02: Update options that depend on 'which-key-dont-use-unicode' Robert Pluim
2024-06-24 15:01     ` Philip Kaludercic
2024-06-24 17:14       ` Robert Pluim
2024-06-24 18:49         ` Philip Kaludercic
2024-07-11  9:40           ` Robert Pluim [this message]
2024-07-12 13:40             ` Philip Kaludercic
2024-07-12 14:38               ` Robert Pluim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bk34i7wk.fsf@gmail.com \
    --to=rpluim@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=philipk@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).