From: Helmut Eller <eller.helmut@gmail.com>
To: "Gerd Möllmann" <gerd.moellmann@gmail.com>
Cc: "Gerd Möllmann" <gerd@gnu.org>,
"Stefan Monnier" <monnier@iro.umontreal.ca>,
"Pip Cet" <pipcet@protonmail.com>,
"Ihor Radchenko" <yantar92@posteo.net>,
emacs-devel@gnu.org
Subject: Re: MPS: marker-vector
Date: Tue, 06 Aug 2024 08:02:32 +0200 [thread overview]
Message-ID: <87bk26429z.fsf@gmail.com> (raw)
In-Reply-To: <m24j7ywbca.fsf@pro2.fritz.box> ("Gerd Möllmann"'s message of "Tue, 06 Aug 2024 05:59:17 +0200")
On Tue, Aug 06 2024, Gerd Möllmann wrote:
>> So the results of the growable array and the linked-list-of-markers
>> would be closer. A downside of the growable array is that it needs a
>> bit of extra code for the dumper. I didn't try to port the gap array
>> code, because it seems like it would require many more changes and would
>> make it even harder to merge with master.
>
> Hm, can't say much about the benchmark, I'm afraid. I've been
> successfully ignoring this topic so far :-). I don't even know what the
> impact of these numbers in a larger context is.
>
> That said, if you find it important, I trust that, so no objections from
> me.
Then I will ignore this too.
> Technically speaking, from reading the diff, I think it's okay. The only
> thing I'm wondering about is the compacting of the vector while
> iterating over it. I can't put my finger on it, but Is that always safe?
Modifying/adding/removing array entries while iterating over it is
definitely problematic. But that that's probably also problematic for
the vector-with-free-list.
next prev parent reply other threads:[~2024-08-06 6:02 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-04 4:59 Markers in a gap array Stefan Monnier
2024-07-04 10:24 ` Ihor Radchenko
2024-07-04 13:16 ` Stefan Monnier
2024-07-04 14:30 ` Ihor Radchenko
2024-07-04 20:11 ` Stefan Monnier
2024-07-04 20:34 ` Pip Cet
2024-07-04 20:42 ` Stefan Monnier
2024-07-17 16:48 ` Helmut Eller
2024-07-18 20:46 ` Stefan Monnier
2024-07-26 19:48 ` Helmut Eller
2024-08-05 19:54 ` MPS: marker-vector (was: Markers in a gap array) Helmut Eller
2024-08-05 21:14 ` MPS: marker-vector Pip Cet
2024-08-06 6:28 ` Helmut Eller
2024-08-06 6:51 ` Gerd Möllmann
2024-08-06 14:36 ` Pip Cet
2024-08-06 16:15 ` Helmut Eller
2024-08-06 3:59 ` Gerd Möllmann
2024-08-06 6:02 ` Helmut Eller [this message]
2024-07-04 22:24 ` Markers in a gap array Stefan Monnier
2024-07-07 12:31 ` Ihor Radchenko
2024-07-07 13:09 ` Konstantin Kharlamov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bk26429z.fsf@gmail.com \
--to=eller.helmut@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=gerd.moellmann@gmail.com \
--cc=gerd@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=pipcet@protonmail.com \
--cc=yantar92@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).