`play-sound-file', no mp3 support, sets global volume w/o reset

`play-sound-file', no mp3 support, sets global volume w/o reset

[Emanuel Berg]

`play-sound-file' doesn't play mp3 files, but it could, as the
MP3 patent expired in 2017. (So between 6y 8m 4d and 7y 8m 3d ago.)

But you can easily convert convert an .mp3 file into an .au
file with

  $ ffmpeg -i src.mp3 dst.au

But play-sound-file has another problem, namely, if you do e.g.

  (play-sound-file (file-name-concat bad-dir "data" "up.au") 0.4)

it sets the global volume to 40% and worse, after it is done,
it isn't reset.

-- 
underground experts united
https://dataswamp.org/~incal

Re: `play-sound-file', no mp3 support, sets global volume w/o reset

[Emanuel Berg]

> But play-sound-file has another problem, namely, if you do
> e.g.
>
>   (play-sound-file (file-name-concat bad-dir "data" "up.au") 0.4)
>
> it sets the global volume to 40% and worse, after it is
> done, it isn't reset.

Did anyone check this out?

If unsolved, in practice it means one cannot use it.
My Russian eurodance plays loud and clear at 30-40%.
Just imagine I execute some code that plays a sound at 100%
and then don't reset. The whole block would be dancing.

So while most people would probably just never use a program
again if they know they have to reset their settings
afterwards, it actually could be even dangerous.

Also, another bad thing is that the command monopolizes
execution. I know Elisp is single-threaded and the idle timer
and C threads don't change that, but what about
a child process?

Would that work?

-- 
underground experts united
https://dataswamp.org/~incal

Re: `play-sound-file', no mp3 support, sets global volume w/o reset

[Stefan Kangas]

Emanuel Berg <incal@dataswamp.org> writes:

>> But play-sound-file has another problem, namely, if you do
>> e.g.
>>
>>   (play-sound-file (file-name-concat bad-dir "data" "up.au") 0.4)
>>
>> it sets the global volume to 40% and worse, after it is
>> done, it isn't reset.
>
> Did anyone check this out?

Please report this to the bug tracker, with all the details.

> Also, another bad thing is that the command monopolizes
> execution. I know Elisp is single-threaded and the idle timer
> and C threads don't change that, but what about
> a child process?

See etc/TODO:

** Make play-sound asynchronous and non-blocking

Patches welcome.

Re: `play-sound-file', no mp3 support, sets global volume w/o reset

[Emanuel Berg]

Stefan Kangas wrote:

>> Did anyone check this out?
>
> Please report this to the bug tracker, with all the details.

Okay, sure!

>> Also, another bad thing is that the command monopolizes
>> execution. I know Elisp is single-threaded and the idle
>> timer and C threads don't change that, but what about
>> a child process?
>
> See etc/TODO:
>
> ** Make play-sound asynchronous and non-blocking
>
> Patches welcome.

I'm busy with another project that is already huge but I just
can't finnish it, it seems, but when I do I want to contribute
to Emacs in some way or another, God willing.

Here is a screenshot - it looks OK - well, more than OK - but
when I started out with eieio there were so many things
I didn't know, so I made it work anyway, but now I see how to
do it their way, the right/intended way, and more often than
not I agree, so now I an cleaning up certain habits from 34
files that worked excellently, just to impose tons of bug
trying to do it in a better way :)

  https://dataswamp.org/~incal/emacs-init/bad/meta/cat.png

-- 
underground experts united
https://dataswamp.org/~incal

Re: `play-sound-file', no mp3 support, sets global volume w/o reset

[Björn Bidar]

Emanuel Berg <incal@dataswamp.org> writes:

>> But play-sound-file has another problem, namely, if you do
>> e.g.
>>
>>   (play-sound-file (file-name-concat bad-dir "data" "up.au") 0.4)
>>
>> it sets the global volume to 40% and worse, after it is
>> done, it isn't reset.

> Also, another bad thing is that the command monopolizes
> execution. I know Elisp is single-threaded and the idle timer
> and C threads don't change that, but what about
> a child process?


I recently looked into this as I wanted to play a sound when sending a
notification in Emacs.

There's package that implements a async play-sound using the async
package:
https://github.com/jcs-elpa/sound-async/blob/master/sound-async.el#L43