From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: Reconsider defaults for use-package-vc-prefer-newest Date: Fri, 20 Sep 2024 15:14:26 +0000 Message-ID: <87bk0inyr1.fsf@posteo.net> References: <87wmj7dftf.fsf@posteo.net> <87setvxyt6.fsf@gmail.com> <87jzf7o13b.fsf@posteo.net> <87frpvo06a.fsf@posteo.net> <86y13m7swd.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36769"; mail-complaints-to="usenet@ciao.gmane.io" Cc: suhailsingh247@gmail.com, meedstrom@runbox.eu, emacs-devel@gnu.org, tonyzorman@mailbox.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Sep 20 17:15:22 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1srfLt-0009QQ-T6 for ged-emacs-devel@m.gmane-mx.org; Fri, 20 Sep 2024 17:15:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1srfLC-0002b0-Kx; Fri, 20 Sep 2024 11:14:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1srfLA-0002T1-Fp for emacs-devel@gnu.org; Fri, 20 Sep 2024 11:14:36 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1srfL5-0004Bg-Ej for emacs-devel@gnu.org; Fri, 20 Sep 2024 11:14:36 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id A6651240028 for ; Fri, 20 Sep 2024 17:14:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1726845267; bh=/p/m0ATdBRjPMXvhvhB16U1L50rBVY+GMG7q1pbRfaM=; h=From:To:Cc:Subject:Autocrypt:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:Content-Transfer-Encoding:From; b=aQRjxUSYnQpSWlWIjiZUDKPgf96j22nqtZBI0yOfbCnIOSZLXS6l0L+i6/i6B/ShI rCx7vt/Bih6mhlaIS7mclOSWTgzrjAhIcCSvvv/lVJ+oFUJgKzIa5qtzgjnMIgORmn 4brGIjuyH4X8P+uqQhOdUcGWI5pQrp1V0xmgjKmek1HUxaTMzLQ2bCi3m4D3qDesBb ksqkRrG+Sg9MgLNTUONX/5DamWQ4Y9wV0F20PPb8MwEpWCqEpccMU3BAgN49X/VYPB L8r9NaksG35u4CTydFQTeK4f0acwPpL9AoZ/cajwsoLPYr7qRdel4L83yGDpwUE+Bl UXTVba99qgnFw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4X9GBp41Pnz6tn4; Fri, 20 Sep 2024 17:14:26 +0200 (CEST) In-Reply-To: <86y13m7swd.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 20 Sep 2024 09:15:14 +0300") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM OpenPGP: id=philipk@posteo.net; url="https://keys.openpgp.org/vks/v1/by-email/philipk@posteo.net"; preference=signencrypt Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:323845 Archived-At: Eli Zaretskii writes: >> From: Philip Kaludercic >> Cc: Martin Edstr=C3=B6m , "emacs-devel" >> , Tony Zorman >> Date: Thu, 19 Sep 2024 20:31:25 +0000 >>=20 >> >>> The current approach is to find the newest commit that touches a >> >>> version header and use that. >> >> >> >> Would it be possible to reflect the commit corresponding to the versi= on >> >> in the "Other versions:" field in the output of M-x describe-package ? >> > >> > Why under "Other version:" (which links to other packages). IIRC the >> > commit of a VC package should appear under the commit header. There is >> > the possibility of using a symbolic name if available. >> > >> > I now notice that this is not the case as I had assumed... I'll try to >> > fix it as soon as possible. >>=20 >> This is the fix: > > Can you explain in plain English what this does? Sure, each package has a description object (search for "(cl-defstruct (package-desc" in package.el), with some fixed attributes like name, version, dependencies and others that are stored in an alist. The commit used to create a package is one such attribute stored in the "extras" slot of a package-desc. My chance modifies the package description given by the ELPA server and updates the :commit field to store the commit that was checked out when the package was built locally. I hope that is clear enough? --=20 Philip Kaludercic on siskin