Re: Reconsider defaults for use-package-vc-prefer-newest

[Philip Kaludercic <philipk@posteo.net>]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Philip Kaludercic <philipk@posteo.net>
>> Cc: Martin Edström <meedstrom@runbox.eu>,  "emacs-devel"
>>  <emacs-devel@gnu.org>,  Tony Zorman <tonyzorman@mailbox.org>
>> Date: Thu, 19 Sep 2024 20:31:25 +0000
>> 
>> >>> The current approach is to find the newest commit that touches a
>> >>> version header and use that.
>> >>
>> >> Would it be possible to reflect the commit corresponding to the version
>> >> in the "Other versions:" field in the output of M-x describe-package ?
>> >
>> > Why under "Other version:" (which links to other packages).  IIRC the
>> > commit of a VC package should appear under the commit header.  There is
>> > the possibility of using a symbolic name if available.
>> >
>> > I now notice that this is not the case as I had assumed... I'll try to
>> > fix it as soon as possible.
>> 
>> This is the fix:
>
> Can you explain in plain English what this does?

Sure, each package has a description object (search for "(cl-defstruct
(package-desc" in package.el), with some fixed attributes like name,
version, dependencies and others that are stored in an alist.  The
commit used to create a package is one such attribute stored in the
"extras" slot of a package-desc.  My chance modifies the package
description given by the ELPA server and updates the :commit field to
store the commit that was checked out when the package was built
locally.  I hope that is clear enough?

-- 
	Philip Kaludercic on siskin