From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Christopher Howard Newsgroups: gmane.emacs.devel Subject: bookmark+: legacy key syntax in Emacs 30? Date: Wed, 16 Oct 2024 11:59:27 -0800 Message-ID: <87bjzjstsw.fsf_-_@librehacker.com> References: <87bjzqp9dv.fsf@librehacker.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3407"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Emacs Devel Mailing List To: Drew Adams Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Oct 16 22:00:20 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t1ABv-0000gb-JK for ged-emacs-devel@m.gmane-mx.org; Wed, 16 Oct 2024 22:00:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t1ABH-0002OK-39; Wed, 16 Oct 2024 15:59:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t1ABF-0002Nv-Fu for emacs-devel@gnu.org; Wed, 16 Oct 2024 15:59:37 -0400 Original-Received: from mx.kolabnow.com ([212.103.80.155]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t1ABD-0007br-UV for emacs-devel@gnu.org; Wed, 16 Oct 2024 15:59:37 -0400 Original-Received: from localhost (unknown [127.0.0.1]) by mx.kolabnow.com (Postfix) with ESMTP id D1675354FAA4; Wed, 16 Oct 2024 21:59:33 +0200 (CEST) Authentication-Results: ext-mx-out011.mykolab.com (amavis); dkim=pass (2048-bit key) reason="pass (just generated, assumed good)" header.d=kolabnow.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kolabnow.com; h= content-type:content-type:mime-version:message-id:date:date :references:in-reply-to:subject:subject:from:from:received :received:received; s=dkim20240523; t=1729108773; x=1730923174; bh=o/uc7XufgQIskHStm+491U5eRNxj35rPbB9mHu8D0WM=; b=E1ItH7hvBK0q QxFN8e2mGf84es1bhyIPBV93zapR/H5VQJCotE5y9jbeG9UbAFj9KpnAH98bdas0 PiP7hQpQO7k+iL4HjzxPaPSl5RZ/D9jdVY4dZX/NFUYUz8Li/uJMWCE31JStSnK4 8zVNRLLynL0tccgYO1fo5nCZG2yHe65iQPkmsN1a74C/DkDe1/cCi13tPq1UuV/d 1A14tbtkp6Ib/c7VLPwbK4c+cHAruDhacpdOWyjEahxzdbGh6WlLOTV8Le8MyMUq llRlbPphLZzwPea2HRj7hFvYALa6rtq47hvx9suGnHYAfkWbqEXDXrxNG653jKup sQrdJR+pfA== X-Virus-Scanned: amavis at mykolab.com Original-Received: from mx.kolabnow.com ([127.0.0.1]) by localhost (ext-mx-out011.mykolab.com [127.0.0.1]) (amavis, port 10024) with ESMTP id LI_VOc5mBhFy; Wed, 16 Oct 2024 21:59:33 +0200 (CEST) Original-Received: from int-mx011.mykolab.com (unknown [10.9.13.11]) by mx.kolabnow.com (Postfix) with ESMTPS id CDEB1354FAA3; Wed, 16 Oct 2024 21:59:32 +0200 (CEST) Original-Received: from ext-subm010.mykolab.com (unknown [10.9.6.10]) by int-mx011.mykolab.com (Postfix) with ESMTPS id 134D030AF2F8; Wed, 16 Oct 2024 21:59:32 +0200 (CEST) In-Reply-To: (Drew Adams's message of "Sat, 12 Oct 2024 00:58:00 +0000") Received-SPF: none client-ip=212.103.80.155; envelope-from=christopher@librehacker.com; helo=mx.kolabnow.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:324612 Archived-At: I downloaded the latest files from the wiki but am still getting the same error when I require 'bookmark+. I do not know much about keymaps at this point, but the offending line is in bookmark+-key.el: ``` elisp (define-key ctl-x-map "rK" 'bmkp-set-desktop-bookmark) ; `C-x r K' (also `C-x x K', `C-x x c K') ``` I see in the Emacs 30 documentation at least that define-key is considered now a legacy function, and `keymap-set' is recommended instead. Perhaps something broke in define-key from 29->30, so that it no longer recognizes correctly the legacy string syntax? I'm CC'ing emacs-devel in hopes that an SME will weigh in on this. -- Christopher Howard