From: Christopher Howard <christopher@librehacker.com>
To: Drew Adams <drew.adams@oracle.com>
Cc: Emacs Devel Mailing List <emacs-devel@gnu.org>
Subject: bookmark+: legacy key syntax in Emacs 30?
Date: Wed, 16 Oct 2024 11:59:27 -0800 [thread overview]
Message-ID: <87bjzjstsw.fsf_-_@librehacker.com> (raw)
In-Reply-To: <DS7PR10MB523229744E69BFEBB3ACB1D0F37A2@DS7PR10MB5232.namprd10.prod.outlook.com> (Drew Adams's message of "Sat, 12 Oct 2024 00:58:00 +0000")
I downloaded the latest files from the wiki but am still getting the same error when I require 'bookmark+.
I do not know much about keymaps at this point, but the offending line is in bookmark+-key.el:
``` elisp
(define-key ctl-x-map "rK" 'bmkp-set-desktop-bookmark) ; `C-x r K' (also `C-x x K', `C-x x c K')
```
I see in the Emacs 30 documentation at least that define-key is considered now a legacy function, and `keymap-set' is recommended instead. Perhaps something broke in define-key from 29->30, so that it no longer recognizes correctly the legacy string syntax?
I'm CC'ing emacs-devel in hopes that an SME will weigh in on this.
--
Christopher Howard
next parent reply other threads:[~2024-10-16 19:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87bjzqp9dv.fsf@librehacker.com>
[not found] ` <DS7PR10MB523229744E69BFEBB3ACB1D0F37A2@DS7PR10MB5232.namprd10.prod.outlook.com>
2024-10-16 19:59 ` Christopher Howard [this message]
2024-10-17 7:34 ` bookmark+: legacy key syntax in Emacs 30? Robert Pluim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bjzjstsw.fsf_-_@librehacker.com \
--to=christopher@librehacker.com \
--cc=drew.adams@oracle.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).