From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Pengji Zhang Newsgroups: gmane.emacs.devel Subject: Re: Comint-like history search for Eshell? Date: Mon, 04 Nov 2024 19:47:35 +0800 Message-ID: <87bjyv2pbc.fsf@pengjiz.com> References: <878qu01mfc.fsf@pengjiz.com> <4fca840c-f6f3-53af-a020-11427efc07e7@gmail.com> <875xp3mqdb.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24982"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Juri Linkov , Jim Porter Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Nov 04 12:50:07 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t7vav-0006HK-7u for ged-emacs-devel@m.gmane-mx.org; Mon, 04 Nov 2024 12:50:05 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t7va2-0001ym-Ib; Mon, 04 Nov 2024 06:49:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t7vYj-0001hZ-HQ for emacs-devel@gnu.org; Mon, 04 Nov 2024 06:47:49 -0500 Original-Received: from fhigh-b1-smtp.messagingengine.com ([202.12.124.152]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t7vYh-0002DE-Bn for emacs-devel@gnu.org; Mon, 04 Nov 2024 06:47:49 -0500 Original-Received: from phl-compute-08.internal (phl-compute-08.phl.internal [10.202.2.48]) by mailfhigh.stl.internal (Postfix) with ESMTP id 10541254009B; Mon, 4 Nov 2024 06:47:46 -0500 (EST) Original-Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-08.internal (MEProxy); Mon, 04 Nov 2024 06:47:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pengjiz.com; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1730720865; x=1730807265; bh=v/JToNBrHS rimfK8+I6vEqj467osajZaLvNRJ5e0rfE=; b=iZajbccBRS9qdbG3Bio8tRDL3k Xl/cvyE6gVQgwZ/DiskiOpWDLMwL1pn93wwoSpWn+QgDM8kkZT5CtzJJDWBYPbDd uEEbtsyweTNfpydsN85MhWK53ZgbxURyA7TjTNkjt4qxLLsohqK2mVOs3RUcfJqM BPK1BHADhcZ/z+P3OU95+8qOX/hn4PLDEzAm6JE2vWVXnjg16Y1ojbnxaxNbVtVU GlC7pbORYXRWJP7UE5t89NOwrM5SdZUu18eICpvGdwCf40is7AbQ55RqGUHosLuP vpMEeFupnGJdhUkFwzQJmkGlqcg+bDlr7NI9s4DuXwBK5gdBvE80ojCpsogQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1730720865; x=1730807265; bh=v/JToNBrHSrimfK8+I6vEqj467osajZaLvN RJ5e0rfE=; b=oUkEZDHswAYNr8HtSI5xXgYl6IJ9/aRWBvKM73bHL2Aj6QVtLTt p5yYFAWub5L7va92tonFUhhsjx91XlLI9CEVAlcRfdw9+kmnHN+AOaWLOM2NvgDW sCevjs9URhjVlaTVY39dIUhYRwNKifydiJ1J9gjyFFRCzVucyTWie64LT/1TKojn G4v3xkfSYX0mtOIXHGl6l2v1q0sq4GQcIQpyfLNl2nDtcV3oyw9ob34vAouYl1yt CgdTUHx96z+dwywAVUvlP3Ly+8R9RBpGJLi+98pslfRaRNyLI7vZsQAvWUxyNj6H pyeLAQ4VYBfDiiYbkCaMjlVGnDWpckvDIPw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdeliedgfeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhephffvvefujghffffkgggtsehttdertddttddtnecu hfhrohhmpefrvghnghhjihcukghhrghnghcuoehmvgesphgvnhhgjhhiiidrtghomheqne cuggftrfgrthhtvghrnhepgeefieeivddukeeitdegudeftdevtdeuteeifffhvdehffet gfeijeeileelheegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepmhgvsehpvghnghhjihiirdgtohhmpdhnsggprhgtphhtthhopeefpdhmohgu vgepshhmthhpohhuthdprhgtphhtthhopehjuhhriheslhhinhhkohhvrdhnvghtpdhrtg hpthhtohepjhhpohhrthgvrhgsuhhgshesghhmrghilhdrtghomhdprhgtphhtthhopegv mhgrtghsqdguvghvvghlsehgnhhurdhorhhg X-ME-Proxy: Feedback-ID: i16614472:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 4 Nov 2024 06:47:44 -0500 (EST) In-Reply-To: <875xp3mqdb.fsf@mail.linkov.net> Received-SPF: pass client-ip=202.12.124.152; envelope-from=me@pengjiz.com; helo=fhigh-b1-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Mon, 04 Nov 2024 06:49:02 -0500 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:325088 Archived-At: Juri Linkov writes: > The standard features that correspond to these two ways are > incremental search with 'C-s' (implemented in the proposed patch) > and occur with 'M-s o' (there is no occur-like interface for Eshell > history AFAIK, it exists only for the minibuffer history, and > in shell with 'comint-dynamic-list-input-ring'). In Eshell there is 'eshell-list-history', but it filters the history using the bang expansion syntax, which is disabled by default now. In Eshell, you may type 'C-c C-l' after $ !emacs to get a buffer showing all history commands that start with 'emacs'. I do not use bang expansion so I find it rarely useful. > [...] > > So Eshell could have both as well: incremental search and completion. I agree that we could implement both. For completion, if we are going to let-bind 'completion-at-point-functions' as in Juri's and Sean's commands (or use 'completion-in-region' as we do for the minibuffer), then IMO there is nothing that hinders the implementation of an Isearch interface. Pengji