unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Mario Lang <mlang@delysid.org>
Cc: emacs-devel@gnu.org
Subject: Re: temp_echo_area_glyphs and Emacspeak
Date: Sat, 07 Sep 2002 15:11:46 +0200	[thread overview]
Message-ID: <87admu0wrx.fsf@lexx.delysid.org> (raw)
In-Reply-To: <E17nW5r-00084q-00@fencepost.gnu.org> (Richard Stallman's message of "Fri, 06 Sep 2002 23:17:07 -0400")

Richard Stallman <rms@gnu.org> writes:

> The code you wrote looks correct, but this part is not needed:
>
>     +  DEFVAR_LISP ("temp-echo-area-message-hook", &Vtemp_echo_area_message_hook,
>     +	       doc: /* Normal hook run with temp-echo-area-message
>     +as argument. */);
>     +  Vtemp_echo_area_message_hook = Qnil;
>
> Vtemp_echo_area_message_hook is not needed at all,
> because the real implementation does not use it.
> Just defvar it in Lisp.
OK, I'll do this at the beginning of next wekk.

Just one question: Where should the lisp defvar go?  I didn't
find any suitable .el file in lisp/ at first glance.

>     > How does Emacspeak find out about ordinary calls to `message'?
>     It uses defadvice.
>
> That won't work reliably--calls from within the C code won't be
> caught.  A message-hook would work more reliably.  Would you like to
> write that?

Yes, will do.  I looked at the code, and I'm a bit confused
where to call such a  message-hook actually.
At first glance, I'd say in message3 in xdisp.c, but there is also message2
and the various no_log and dolog variants.

Also, should I define message-hook also in Lisp, and if yes, where?

-- 
Thanks,
  Mario

  reply	other threads:[~2002-09-07 13:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-09-05 13:35 temp_echo_area_glyphs and Emacspeak Mario Lang
2002-09-06  4:01 ` Richard Stallman
2002-09-06 13:24   ` Mario Lang
2002-09-07  3:17     ` Richard Stallman
2002-09-07 13:11       ` Mario Lang [this message]
2002-09-09  0:22         ` Richard Stallman
2002-09-06 17:15 ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87admu0wrx.fsf@lexx.delysid.org \
    --to=mlang@delysid.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).